Issue 11973035: Added heap capacity and used space status methods, for use by status tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11973035: Added heap capacity and used space status methods, for use by status tools. (Closed)

Created:
7 years, 11 months ago by Tom Ball

Modified:
7 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added heap capacity and used space status methods, for use by status tools. Committed: https://code.google.com/p/dart/source/detail?r=17235

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	runtime/vm/heap.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	runtime/vm/heap.cc	View		1 chunk	+10 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Ball

These are the two files from the unsubmitted status tool CL, unchanged.

7 years, 11 months ago (2013-01-17 17:36:25 UTC) #1

siva

lgtm https://chromiumcodereview.appspot.com/11973035/diff/1/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://chromiumcodereview.appspot.com/11973035/diff/1/runtime/vm/heap.cc#newcode281 runtime/vm/heap.cc:281: (old_space_->in_use() / KB), (old_space_->capacity() / KB)); We could ...

7 years, 11 months ago (2013-01-17 19:29:03 UTC) #2

Tom Ball

7 years, 11 months ago (2013-01-17 19:43:55 UTC) #3

https://chromiumcodereview.appspot.com/11973035/diff/1/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

https://chromiumcodereview.appspot.com/11973035/diff/1/runtime/vm/heap.cc#new...
runtime/vm/heap.cc:281: (old_space_->in_use() / KB), (old_space_->capacity() /
KB));
On 2013/01/17 19:29:03, siva wrote:
> We could use your new functions here right (that way it gets exercised):
> 
> (Used(kNew) / KB), (Capacity(kNew) / KB),
> (Used(kOld) / KB), (Capacity(kOld) / KB));

Done.

Expand Messages | Collapse Messages