Fixes leak of NativeTextfieldWin. The underlying HWND was getting

Fixes leak of NativeTextfieldWin. The underlying HWND was getting
destroyed (by virtue of being a child HWND), but the
NativeTextfieldWin was never destroying itself.

BUG=170369
TEST=none
R=ben@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177195

[Ben Goodger (Google), 2013-01-16 17:10:22]

lgtm


On Wed, Jan 16, 2013 at 8:43 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fixes leak of NativeTextfieldWin. The underlying HWND was getting
> destroyed (by virtue of being a child HWND), but the
> NativeTextfieldWin was never destroying itself.
>
> BUG=170369
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
https://codereview.chromium.**org/11973011/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ui/views/controls/textfield/**native_textfield_win.h
>   M ui/views/controls/textfield/**native_textfield_win.cc
>
>
> Index: ui/views/controls/textfield/**native_textfield_win.cc
> diff --git a/ui/views/controls/textfield/**native_textfield_win.cc
> b/ui/views/controls/textfield/**native_textfield_win.cc
> index b6fb41d202c8b2769fbbdf889cace1**073872d653..**
> dc36ebfb60e47bd84ab8b5dda67dca**bb15b299e1 100644
> --- a/ui/views/controls/textfield/**native_textfield_win.cc
> +++ b/ui/views/controls/textfield/**native_textfield_win.cc
> @@ -1084,6 +1084,10 @@ void NativeTextfieldWin::OnSysChar(**TCHAR ch,
> UINT repeat_count, UINT flags) {
>      SetMsgHandled(false);
>  }
>
> +void NativeTextfieldWin::**OnFinalMessage(HWND hwnd) {
> +  delete this;
> +}
> +
>  void NativeTextfieldWin::**HandleKeystroke() {
>    const MSG* msg = GetCurrentMessage();
>    ScopedFreeze freeze(this, GetTextObjectModel());
> Index: ui/views/controls/textfield/**native_textfield_win.h
> diff --git a/ui/views/controls/textfield/**native_textfield_win.h
> b/ui/views/controls/textfield/**native_textfield_win.h
> index eca2358cd9e9b117c49daffb9a0ff6**3fcab53c03..**
> f9b8f268b56b3bec516feea334c4e5**acfd709a01 100644
> --- a/ui/views/controls/textfield/**native_textfield_win.h
> +++ b/ui/views/controls/textfield/**native_textfield_win.h
> @@ -219,6 +219,9 @@ class NativeTextfieldWin
>    void OnKillFocus(HWND hwnd);
>    void OnSysChar(TCHAR ch, UINT repeat_count, UINT flags);
>
> +  // CWindowImpl overrides:
> +  virtual void OnFinalMessage(HWND hwnd) OVERRIDE;
> +
>    // Helper function for OnChar() and OnKeyDown() that handles keystrokes
> that
>    // could change the text in the edit.
>    // Note: This function assumes GetCurrentMessage() returns a MSG with
>
>
>

[commit-bot: I haz the power, 2013-01-16 17:16:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/11973011/1

[commit-bot: I haz the power, 2013-01-16 19:34:05]

Change committed as 177195