Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: ui/views/controls/textfield/native_textfield_win.h

Issue 11973011: Fixes leak of NativeTextfieldWin. The underlying HWND was getting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ui/views/controls/textfield/native_textfield_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_ 5 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_
6 #define UI_VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_ 6 #define UI_VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_
7 7
8 #include <atlbase.h> 8 #include <atlbase.h>
9 #include <atlapp.h> 9 #include <atlapp.h>
10 #include <atlcrack.h> 10 #include <atlcrack.h>
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 LRESULT OnMouseWheel(UINT message, WPARAM w_param, LPARAM l_param); 212 LRESULT OnMouseWheel(UINT message, WPARAM w_param, LPARAM l_param);
213 void OnMouseMove(UINT keys, const CPoint& point); 213 void OnMouseMove(UINT keys, const CPoint& point);
214 int OnNCCalcSize(BOOL w_param, LPARAM l_param); 214 int OnNCCalcSize(BOOL w_param, LPARAM l_param);
215 void OnNCPaint(HRGN region); 215 void OnNCPaint(HRGN region);
216 void OnNonLButtonDown(UINT keys, const CPoint& point); 216 void OnNonLButtonDown(UINT keys, const CPoint& point);
217 void OnPaste(); 217 void OnPaste();
218 void OnSetFocus(HWND hwnd); 218 void OnSetFocus(HWND hwnd);
219 void OnKillFocus(HWND hwnd); 219 void OnKillFocus(HWND hwnd);
220 void OnSysChar(TCHAR ch, UINT repeat_count, UINT flags); 220 void OnSysChar(TCHAR ch, UINT repeat_count, UINT flags);
221 221
222 // CWindowImpl overrides:
223 virtual void OnFinalMessage(HWND hwnd) OVERRIDE;
224
222 // Helper function for OnChar() and OnKeyDown() that handles keystrokes that 225 // Helper function for OnChar() and OnKeyDown() that handles keystrokes that
223 // could change the text in the edit. 226 // could change the text in the edit.
224 // Note: This function assumes GetCurrentMessage() returns a MSG with 227 // Note: This function assumes GetCurrentMessage() returns a MSG with
225 // msg > WM_KEYFIRST and < WM_KEYLAST. 228 // msg > WM_KEYFIRST and < WM_KEYLAST.
226 void HandleKeystroke(); 229 void HandleKeystroke();
227 230
228 // Every piece of code that can change the edit should call these functions 231 // Every piece of code that can change the edit should call these functions
229 // before and after the change. These functions determine if anything 232 // before and after the change. These functions determine if anything
230 // meaningful changed, and do any necessary updating and notification. 233 // meaningful changed, and do any necessary updating and notification.
231 void OnBeforePossibleChange(); 234 void OnBeforePossibleChange();
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 int accessibility_state_; 318 int accessibility_state_;
316 319
317 scoped_ptr<ui::TSFEventRouter> tsf_event_router_; 320 scoped_ptr<ui::TSFEventRouter> tsf_event_router_;
318 321
319 DISALLOW_COPY_AND_ASSIGN(NativeTextfieldWin); 322 DISALLOW_COPY_AND_ASSIGN(NativeTextfieldWin);
320 }; 323 };
321 324
322 } // namespace views 325 } // namespace views
323 326
324 #endif // UI_VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_ 327 #endif // UI_VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | ui/views/controls/textfield/native_textfield_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698