Issue 119713003: Add base:: to string16s in sandbox/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119713003: Add base:: to string16s in sandbox/. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
nsylvain, rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -69 lines)			Patch
M	sandbox/win/src/app_container.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	sandbox/win/src/app_container.cc	View	6 chunks	+11 lines, -10 lines	0 comments	Download
M	sandbox/win/src/app_container_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sandbox/win/src/app_container_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/win/src/broker_services.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sandbox/win/src/handle_closer.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sandbox/win/src/handle_closer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/win/src/handle_closer_test.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	sandbox/win/src/handle_table.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sandbox/win/src/handle_table.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sandbox/win/src/process_policy_test.cc	View	15 chunks	+24 lines, -24 lines	0 comments	Download
M	sandbox/win/src/sandbox_policy_base.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sandbox/win/src/sandbox_policy_base.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/119713003/1

7 years ago (2013-12-20 20:55:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r242214 (presubmit successful).