Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: sandbox/win/src/handle_closer_test.cc

Issue 119713003: Add base:: to string16s in sandbox/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sandbox/win/src/handle_closer.cc ('k') | sandbox/win/src/handle_table.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "base/win/scoped_handle.h" 6 #include "base/win/scoped_handle.h"
7 #include "sandbox/win/src/handle_closer_agent.h" 7 #include "sandbox/win/src/handle_closer_agent.h"
8 #include "sandbox/win/src/sandbox.h" 8 #include "sandbox/win/src/sandbox.h"
9 #include "sandbox/win/src/sandbox_factory.h" 9 #include "sandbox/win/src/sandbox_factory.h"
10 #include "sandbox/win/src/target_services.h" 10 #include "sandbox/win/src/target_services.h"
11 #include "sandbox/win/tests/common/controller.h" 11 #include "sandbox/win/tests/common/controller.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 namespace { 14 namespace {
15 15
16 const wchar_t *kFileExtensions[] = { L".1", L".2", L".3", L".4" }; 16 const wchar_t *kFileExtensions[] = { L".1", L".2", L".3", L".4" };
17 17
18 // Returns a handle to a unique marker file that can be retrieved between runs. 18 // Returns a handle to a unique marker file that can be retrieved between runs.
19 HANDLE GetMarkerFile(const wchar_t *extension) { 19 HANDLE GetMarkerFile(const wchar_t *extension) {
20 wchar_t path_buffer[MAX_PATH + 1]; 20 wchar_t path_buffer[MAX_PATH + 1];
21 CHECK(::GetTempPath(MAX_PATH, path_buffer)); 21 CHECK(::GetTempPath(MAX_PATH, path_buffer));
22 string16 marker_path = path_buffer; 22 base::string16 marker_path = path_buffer;
23 marker_path += L"\\sbox_marker_"; 23 marker_path += L"\\sbox_marker_";
24 24
25 // Generate a unique value from the exe's size and timestamp. 25 // Generate a unique value from the exe's size and timestamp.
26 CHECK(::GetModuleFileName(NULL, path_buffer, MAX_PATH)); 26 CHECK(::GetModuleFileName(NULL, path_buffer, MAX_PATH));
27 base::win::ScopedHandle module(::CreateFile(path_buffer, 27 base::win::ScopedHandle module(::CreateFile(path_buffer,
28 FILE_READ_ATTRIBUTES, FILE_SHARE_READ, NULL, 28 FILE_READ_ATTRIBUTES, FILE_SHARE_READ, NULL,
29 OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL)); 29 OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL));
30 CHECK(module.IsValid()); 30 CHECK(module.IsValid());
31 FILETIME timestamp; 31 FILETIME timestamp;
32 CHECK(::GetFileTime(module, &timestamp, NULL, NULL)); 32 CHECK(::GetFileTime(module, &timestamp, NULL, NULL));
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 EXPECT_NE(GetMarkerFile(kFileExtensions[i]), INVALID_HANDLE_VALUE); 69 EXPECT_NE(GetMarkerFile(kFileExtensions[i]), INVALID_HANDLE_VALUE);
70 return SBOX_TEST_SUCCEEDED; 70 return SBOX_TEST_SUCCEEDED;
71 71
72 case AFTER_REVERT: { 72 case AFTER_REVERT: {
73 // Brute force the handle table to find what we're looking for. 73 // Brute force the handle table to find what we're looking for.
74 DWORD handle_count = UINT_MAX; 74 DWORD handle_count = UINT_MAX;
75 const int kInvalidHandleThreshold = 100; 75 const int kInvalidHandleThreshold = 100;
76 const size_t kHandleOffset = sizeof(HANDLE); 76 const size_t kHandleOffset = sizeof(HANDLE);
77 HANDLE handle = NULL; 77 HANDLE handle = NULL;
78 int invalid_count = 0; 78 int invalid_count = 0;
79 string16 handle_name; 79 base::string16 handle_name;
80 80
81 if (!::GetProcessHandleCount(::GetCurrentProcess(), &handle_count)) 81 if (!::GetProcessHandleCount(::GetCurrentProcess(), &handle_count))
82 return SBOX_TEST_FAILED_TO_RUN_TEST; 82 return SBOX_TEST_FAILED_TO_RUN_TEST;
83 83
84 while (handle_count && invalid_count < kInvalidHandleThreshold) { 84 while (handle_count && invalid_count < kInvalidHandleThreshold) {
85 reinterpret_cast<size_t&>(handle) += kHandleOffset; 85 reinterpret_cast<size_t&>(handle) += kHandleOffset;
86 if (GetHandleName(handle, &handle_name)) { 86 if (GetHandleName(handle, &handle_name)) {
87 for (int i = 1; i < argc; ++i) { 87 for (int i = 1; i < argc; ++i) {
88 if (handle_name == argv[i]) 88 if (handle_name == argv[i])
89 return should_find ? SBOX_TEST_SUCCEEDED : SBOX_TEST_FAILED; 89 return should_find ? SBOX_TEST_SUCCEEDED : SBOX_TEST_FAILED;
(...skipping 13 matching lines...) Expand all
103 103
104 return SBOX_TEST_SUCCEEDED; 104 return SBOX_TEST_SUCCEEDED;
105 } 105 }
106 106
107 TEST(HandleCloserTest, CheckForMarkerFiles) { 107 TEST(HandleCloserTest, CheckForMarkerFiles) {
108 TestRunner runner; 108 TestRunner runner;
109 runner.SetTimeout(2000); 109 runner.SetTimeout(2000);
110 runner.SetTestState(EVERY_STATE); 110 runner.SetTestState(EVERY_STATE);
111 sandbox::TargetPolicy* policy = runner.GetPolicy(); 111 sandbox::TargetPolicy* policy = runner.GetPolicy();
112 112
113 string16 command = string16(L"CheckForFileHandles Y"); 113 base::string16 command = base::string16(L"CheckForFileHandles Y");
114 for (int i = 0; i < arraysize(kFileExtensions); ++i) { 114 for (int i = 0; i < arraysize(kFileExtensions); ++i) {
115 string16 handle_name; 115 base::string16 handle_name;
116 base::win::ScopedHandle marker(GetMarkerFile(kFileExtensions[i])); 116 base::win::ScopedHandle marker(GetMarkerFile(kFileExtensions[i]));
117 CHECK(marker.IsValid()); 117 CHECK(marker.IsValid());
118 CHECK(sandbox::GetHandleName(marker, &handle_name)); 118 CHECK(sandbox::GetHandleName(marker, &handle_name));
119 command += (L" "); 119 command += (L" ");
120 command += handle_name; 120 command += handle_name;
121 } 121 }
122 122
123 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(command.c_str())) << 123 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(command.c_str())) <<
124 "Failed: " << command; 124 "Failed: " << command;
125 } 125 }
126 126
127 TEST(HandleCloserTest, CloseMarkerFiles) { 127 TEST(HandleCloserTest, CloseMarkerFiles) {
128 TestRunner runner; 128 TestRunner runner;
129 runner.SetTimeout(2000); 129 runner.SetTimeout(2000);
130 runner.SetTestState(EVERY_STATE); 130 runner.SetTestState(EVERY_STATE);
131 sandbox::TargetPolicy* policy = runner.GetPolicy(); 131 sandbox::TargetPolicy* policy = runner.GetPolicy();
132 132
133 string16 command = string16(L"CheckForFileHandles N"); 133 base::string16 command = base::string16(L"CheckForFileHandles N");
134 for (int i = 0; i < arraysize(kFileExtensions); ++i) { 134 for (int i = 0; i < arraysize(kFileExtensions); ++i) {
135 string16 handle_name; 135 base::string16 handle_name;
136 base::win::ScopedHandle marker(GetMarkerFile(kFileExtensions[i])); 136 base::win::ScopedHandle marker(GetMarkerFile(kFileExtensions[i]));
137 CHECK(marker.IsValid()); 137 CHECK(marker.IsValid());
138 CHECK(sandbox::GetHandleName(marker, &handle_name)); 138 CHECK(sandbox::GetHandleName(marker, &handle_name));
139 CHECK_EQ(policy->AddKernelObjectToClose(L"File", handle_name.c_str()), 139 CHECK_EQ(policy->AddKernelObjectToClose(L"File", handle_name.c_str()),
140 SBOX_ALL_OK); 140 SBOX_ALL_OK);
141 command += (L" "); 141 command += (L" ");
142 command += handle_name; 142 command += handle_name;
143 } 143 }
144 144
145 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(command.c_str())) << 145 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(command.c_str())) <<
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 runner.SetTestState(AFTER_REVERT); 185 runner.SetTestState(AFTER_REVERT);
186 sandbox::TargetPolicy* policy = runner.GetPolicy(); 186 sandbox::TargetPolicy* policy = runner.GetPolicy();
187 187
188 // Sever the CSRSS connection by closing ALPC ports inside the sandbox. 188 // Sever the CSRSS connection by closing ALPC ports inside the sandbox.
189 CHECK_EQ(policy->AddKernelObjectToClose(L"ALPC Port", NULL), SBOX_ALL_OK); 189 CHECK_EQ(policy->AddKernelObjectToClose(L"ALPC Port", NULL), SBOX_ALL_OK);
190 190
191 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"RunThreadPool")); 191 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"RunThreadPool"));
192 } 192 }
193 193
194 } // namespace sandbox 194 } // namespace sandbox
OLDNEW
« no previous file with comments | « sandbox/win/src/handle_closer.cc ('k') | sandbox/win/src/handle_table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698