Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 11970045: Fix failure to write latest_rev updates to database. (Closed)

Created:
7 years, 11 months ago by agable
Modified:
7 years, 11 months ago
Reviewers:
cmp, hinoka
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Fix failure to write latest_rev updates to database. Fixes problem of occasional severely out-of-date consoles, when an app instance without an up-to-date memcache fell back to the datastore for fetching latest_rev. TBR=hinoka BUG=https://code.google.com/p/chromium/issues/detail?id=170494 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=178091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M app.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 11 months ago (2013-01-17 22:09:41 UTC) #1
agable
Quick fix. The old recursive call was a bad idea because of the way get_or_create_row ...
7 years, 11 months ago (2013-01-17 22:11:18 UTC) #2
cmp
lgtm
7 years, 11 months ago (2013-01-22 20:41:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/11970045/1
7 years, 11 months ago (2013-01-22 21:04:25 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-22 21:04:41 UTC) #5
Message was sent while issue was closed.
Change committed as 178091

Powered by Google App Engine
This is Rietveld 408576698