Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(835)

Issue 11968011: Implement Context::GetIsolate() (Closed)

Created:
7 years, 10 months ago by haraken
Modified:
7 years, 10 months ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Implement Context::GetIsolate() BUG= TEST=test-api.cc (IsolateOfContext) Committed: http://code.google.com/p/v8/source/detail?r=13397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M include/v8.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken
WebCore calls V8 bindings here and there. At entry points from WebCore to V8 bindings, ...
7 years, 10 months ago (2013-01-16 09:44:41 UTC) #1
Michael Starzinger
Sven, I think you should review this, since you are currently working on Isolates in ...
7 years, 10 months ago (2013-01-16 10:14:15 UTC) #2
Sven Panne
7 years, 10 months ago (2013-01-16 12:05:40 UTC) #3
LGTM. As discussed offline, in the long run one might have to reconsider the
alternative of storing the Isolate explicitly in the Chrome bindings, e.g.
ScriptExecutionContext and friends.

I'll land this CL for you...

Powered by Google App Engine
This is Rietveld 408576698