Issue 11962031: Move a few non-common css files out of chrome\browser\resources\shared\css. This is in anticipation…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11962031: Move a few non-common css files out of chrome\browser\resources\shared\css. This is in anticipation… (Closed)

Created:
7 years, 11 months ago by jam

Modified:
7 years, 11 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move a few non-common css files out of chrome\browser\resources\shared\css. This is in anticipation of moving chrome\browser\resources\shared to ui\webui. BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177292

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -370 lines)			Patch
M	chrome/browser/browser_resources.grd	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	chrome/browser/resources/about_memory.css	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/about_memory.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/about_memory_linux.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/about_memory_mac.html	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/resources/about_version.css	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/about_version.html	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/shared/css/about_memory.css	View	1 chunk	+0 lines, -298 lines	0 comments	Download
D	chrome/browser/resources/shared/css/about_version.css	View	1 chunk	+0 lines, -62 lines	0 comments	Download
M	chrome/browser/resources/shared_resources.grd	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/about_ui.cc	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/version_ui.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

I looked through the contents of chrome\browser\resources\shared to see if there's stuff that doesn't belong ...

7 years, 11 months ago (2013-01-17 00:28:48 UTC) #1

James Hawkins

7 years, 11 months ago (2013-01-17 00:35:35 UTC) #2

On 2013/01/17 00:28:48, John Abd-El-Malek wrote:
> I looked through the contents of chrome\browser\resources\shared to see if
> there's stuff that doesn't belong in ui\webui. These looked like they didn't
> need to be in the shared directory, similiar to css for other webui pages.

LGTM

Expand Messages | Collapse Messages