Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 11962008: Fix TSAN-detected data race: Sync with audio thread before accessing output_streams_ in unit test c… (Closed)

Created:
7 years, 11 months ago by miu
Modified:
7 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Fix TSAN-detected data race: Sync with audio thread before accessing output_streams_ in unit test code. Removed suppression. BUG=170245 TEST=Ran TSAN analyzer tool before and after fix. Confirmed several runs all succeed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
miu
Hey Tommi, A quick fix for a TSAN failure. TBR'ed to get the unit test ...
7 years, 11 months ago (2013-01-16 04:09:14 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 11 months ago (2013-01-16 04:10:05 UTC) #2
miu
7 years, 11 months ago (2013-01-16 04:12:04 UTC) #3
miu
lgtm
7 years, 11 months ago (2013-01-16 04:12:20 UTC) #4
miu
Meh. Well, I'm supposed to be a full committer. I guess this can wait. Un-TBR'ing ...
7 years, 11 months ago (2013-01-16 04:18:16 UTC) #5
tommi (sloooow) - chröme
lgtm
7 years, 11 months ago (2013-01-16 08:39:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/11962008/1
7 years, 11 months ago (2013-01-16 08:39:39 UTC) #7
Alexander Potapenko
On 2013/01/16 04:18:16, Yuri wrote: > Meh. Well, I'm supposed to be a full committer. ...
7 years, 11 months ago (2013-01-16 08:54:39 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 11:40:37 UTC) #9
Message was sent while issue was closed.
Change committed as 177133

Powered by Google App Engine
This is Rietveld 408576698