Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: media/audio/virtual_audio_input_stream_unittest.cc

Issue 11962008: Fix TSAN-detected data race: Sync with audio thread before accessing output_streams_ in unit test c… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/virtual_audio_input_stream_unittest.cc
diff --git a/media/audio/virtual_audio_input_stream_unittest.cc b/media/audio/virtual_audio_input_stream_unittest.cc
index 93b4b017553fff6eb400541b2cf0904f383457df..5a5be13a599f2935cdade0e30afa2a07eded2778 100644
--- a/media/audio/virtual_audio_input_stream_unittest.cc
+++ b/media/audio/virtual_audio_input_stream_unittest.cc
@@ -161,6 +161,9 @@ class VirtualAudioInputStreamTest
}
void WaitForDataPulls() {
+ // Wait until audio thread is idle before calling output_streams_.size().
+ SyncWithAudioThread();
+
const int count = output_streams_.size();
for (int i = 0; i < count; ++i) {
source_.WaitForDataPulls();
« no previous file with comments | « no previous file | tools/valgrind/tsan/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698