Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/api.cc

Issue 11959031: Add a new weak handle callback that passes an Isolate to an embedder (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index f4a78256ac41417dbe0fa2635bd1dd351b1f610f..17dbfd41adbf648a55d2cd11963b7e5bcc741c6e 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -654,6 +654,15 @@ void V8::MakeWeak(i::Isolate* isolate, i::Object** object,
}
+void V8::WeakenGlobal(i::Isolate* isolate, i::Object** object,
Sven Panne 2013/01/18 08:08:12 no need for this, see other comments
haraken 2013/01/22 00:27:37 Done.
+ void* parameters, WeakenedReferenceCallback callback) {
+ ASSERT(isolate == i::Isolate::Current());
+ LOG_API(isolate, "WeakenGlobal");
+ isolate->global_handles()->MakeWeak(object, parameters,
+ callback);
+}
+
+
void V8::ClearWeak(i::Object** obj) {
i::Isolate* isolate = i::Isolate::Current();
LOG_API(isolate, "ClearWeak");

Powered by Google App Engine
This is Rietveld 408576698