Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: src/api.cc

Issue 11959031: Add a new weak handle callback that passes an Isolate to an embedder (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 647
648 void V8::MakeWeak(i::Isolate* isolate, i::Object** object, 648 void V8::MakeWeak(i::Isolate* isolate, i::Object** object,
649 void* parameters, WeakReferenceCallback callback) { 649 void* parameters, WeakReferenceCallback callback) {
650 ASSERT(isolate == i::Isolate::Current()); 650 ASSERT(isolate == i::Isolate::Current());
651 LOG_API(isolate, "MakeWeak"); 651 LOG_API(isolate, "MakeWeak");
652 isolate->global_handles()->MakeWeak(object, parameters, 652 isolate->global_handles()->MakeWeak(object, parameters,
653 callback); 653 callback);
654 } 654 }
655 655
656 656
657 void V8::WeakenGlobal(i::Isolate* isolate, i::Object** object,
Sven Panne 2013/01/18 08:08:12 no need for this, see other comments
haraken 2013/01/22 00:27:37 Done.
658 void* parameters, WeakenedReferenceCallback callback) {
659 ASSERT(isolate == i::Isolate::Current());
660 LOG_API(isolate, "WeakenGlobal");
661 isolate->global_handles()->MakeWeak(object, parameters,
662 callback);
663 }
664
665
657 void V8::ClearWeak(i::Object** obj) { 666 void V8::ClearWeak(i::Object** obj) {
658 i::Isolate* isolate = i::Isolate::Current(); 667 i::Isolate* isolate = i::Isolate::Current();
659 LOG_API(isolate, "ClearWeak"); 668 LOG_API(isolate, "ClearWeak");
660 isolate->global_handles()->ClearWeakness(obj); 669 isolate->global_handles()->ClearWeakness(obj);
661 } 670 }
662 671
663 672
664 void V8::MarkIndependent(i::Object** object) { 673 void V8::MarkIndependent(i::Object** object) {
665 i::Isolate* isolate = i::Isolate::Current(); 674 i::Isolate* isolate = i::Isolate::Current();
666 LOG_API(isolate, "MarkIndependent"); 675 LOG_API(isolate, "MarkIndependent");
(...skipping 6074 matching lines...) Expand 10 before | Expand all | Expand 10 after
6741 6750
6742 v->VisitPointers(blocks_.first(), first_block_limit_); 6751 v->VisitPointers(blocks_.first(), first_block_limit_);
6743 6752
6744 for (int i = 1; i < blocks_.length(); i++) { 6753 for (int i = 1; i < blocks_.length(); i++) {
6745 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6754 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6746 } 6755 }
6747 } 6756 }
6748 6757
6749 6758
6750 } } // namespace v8::internal 6759 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698