Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Diff against simplified focus Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index cdc6be0f4a629a6fc44bce540f831bc67e269479..ccfbf892a8bbd3517ec36910607133398827f6eb 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -34,6 +34,7 @@ class CONTENT_EXPORT BrowserPlugin :
NON_EXPORTED_BASE(public WebKit::WebPlugin) {
public:
RenderViewImpl* render_view() const { return render_view_.get(); }
+ int render_view_routing_id() const { return render_view_routing_id_; }
bool OnMessageReceived(const IPC::Message& msg);
@@ -175,7 +176,6 @@ class CONTENT_EXPORT BrowserPlugin :
// with the frame within which it lives and the initial attributes assigned
// to it on creation.
BrowserPlugin(
- int instance_id,
RenderViewImpl* render_view,
WebKit::WebFrame* frame,
const WebKit::WebPluginParams& params);
@@ -185,7 +185,6 @@ class CONTENT_EXPORT BrowserPlugin :
int width() const { return plugin_rect_.width(); }
int height() const { return plugin_rect_.height(); }
int instance_id() const { return instance_id_; }
- int render_view_routing_id() const { return render_view_routing_id_; }
BrowserPluginManager* browser_plugin_manager() const {
return browser_plugin_manager_;
}
@@ -244,6 +243,7 @@ class CONTENT_EXPORT BrowserPlugin :
// IPC message handlers.
// Please keep in alphabetical order.
void OnAdvanceFocus(int instance_id, bool reverse);
+ void OnAllocateInstanceIDResponse(int request_id, int instance_id);
void OnBuffersSwapped(int instance_id,
const gfx::Size& size,
std::string mailbox_name,
@@ -313,6 +313,7 @@ class CONTENT_EXPORT BrowserPlugin :
gfx::Size last_view_size_;
bool size_changed_in_flight_;
+ bool allocate_instance_id_in_flight_;
// BrowserPlugin outlives RenderViewImpl in Chrome Apps and so we need to
// store the BrowserPlugin's BrowserPluginManager in a member variable to

Powered by Google App Engine
This is Rietveld 408576698