Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: content/common/browser_plugin_messages.h

Issue 11956022: Browser Plugin: Allocate Instance IDs in BrowserPluginEmbedder instead of BrowserPluginManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Diff against simplified focus Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin_messages.h
diff --git a/content/common/browser_plugin_messages.h b/content/common/browser_plugin_messages.h
index 02a4edd6ce91738868e1678a8bf15f26ea0bf2c4..76e783841a67b0259dce85570a0f78509de9a1ba 100644
--- a/content/common/browser_plugin_messages.h
+++ b/content/common/browser_plugin_messages.h
@@ -56,6 +56,7 @@ IPC_STRUCT_BEGIN(BrowserPluginHostMsg_CreateGuest_Params)
IPC_STRUCT_MEMBER(bool, focused)
IPC_STRUCT_MEMBER(bool, visible)
IPC_STRUCT_MEMBER(std::string, name)
+ IPC_STRUCT_MEMBER(std::string, src)
IPC_STRUCT_MEMBER(BrowserPluginHostMsg_AutoSize_Params, auto_size_params)
IPC_STRUCT_MEMBER(BrowserPluginHostMsg_ResizeGuest_Params,
resize_guest_params)
@@ -121,6 +122,12 @@ IPC_STRUCT_END()
// -----------------------------------------------------------------------------
// These messages are from the embedder to the browser process.
+// This message is sent to the browser process to request an instance ID.
+// |request_id| is used by BrowserPluginEmbedder to route the response back
+// to its origin.
+IPC_MESSAGE_ROUTED1(BrowserPluginHostMsg_AllocateInstanceIDRequest,
+ int /* request_id */)
+
// This message is sent to the browser process to enable or disable autosize
// mode.
IPC_MESSAGE_ROUTED3(
@@ -237,6 +244,13 @@ IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_ResizeGuest,
// -----------------------------------------------------------------------------
// These messages are from the browser process to the embedder.
+// This message is sent from the browser process to the embedder render process
+// in response to a request to allocate an instance ID. The |request_id| is used
+// to route the response to the requestor.
+IPC_MESSAGE_ROUTED2(BrowserPluginMsg_AllocateInstanceIDResponse,
+ int /* request_id */,
+ int /* instance_id*/)
lazyboy 2013/01/17 17:39:25 nit: space after instance_id
Fady Samuel 2013/01/17 18:40:38 Done.
+
// Once the swapped out guest RenderView has been created in the embedder render
// process, the browser process informs the embedder of its routing ID.
IPC_MESSAGE_ROUTED2(BrowserPluginMsg_GuestContentWindowReady,

Powered by Google App Engine
This is Rietveld 408576698