build/android/gyp/lint.py - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/lint.py

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/lint.py

diff --git a/build/android/gyp/lint.py b/build/android/gyp/lint.py

index 9402780b094d3637943779fa0a61b9a4fe2b0192..70d931b9e63ae83753a3d005f857b12a59b32ecb 100755

--- a/build/android/gyp/lint.py

+++ b/build/android/gyp/lint.py

@@ -122,7 +122,7 @@ def _RunLint(lint_path, config_path, processed_config_path, manifest_path,

if not os.path.exists(result_path):

print 'Something is wrong:'

print e

- return 0

+ return 1

newt (away) 2015/06/17 21:00:47 shouldn't we check the value of can_fail_build her

aurimas (slooooooooow) 2015/06/17 21:50:24 Done

# There are actual lint issues

else:

@@ -133,7 +133,7 @@ def _RunLint(lint_path, config_path, processed_config_path, manifest_path,

print 'File contents:'

with open(result_path) as f:

print f.read()

- return 0

+ return 1

_ProcessResultFile()

msg = ('\nLint found %d new issues.\n'

« no previous file with comments | « no previous file | build/android/lint_action.gypi » ('j') | no next file with comments »