Make lint fail builds.

build/android/gyp/lint.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Android's lint tool."""
 
 
 import optparse
@@ skipping 104 matching lines @@
     if os.path.exists(result_path):
       os.remove(result_path)
 
     try:
       build_utils.CheckOutput(cmd, cwd=_SRC_ROOT)
     except build_utils.CalledProcessError as e:
       # There is a problem with lint usage
       if not os.path.exists(result_path):
         print 'Something is wrong:'
         print e
-        return 0
+        return 1

[newt (away), 2015/06/17 21:00:47]

shouldn't we check the value of can_fail_build here? (like we do below)

[aurimas (slooooooooow), 2015/06/17 21:50:24]

Done

 
       # There are actual lint issues
       else:
         try:
           num_issues = _ParseAndShowResultFile()
         except Exception:
           print 'Lint created unparseable xml file...'
           print 'File contents:'
           with open(result_path) as f:
             print f.read()
-          return 0
+          return 1
 
         _ProcessResultFile()
         msg = ('\nLint found %d new issues.\n'
                ' - For full explanation refer to %s\n'
                ' - Wanna suppress these issues?\n'
                '    1. Read comment in %s\n'
                '    2. Run "python %s %s"\n' %
                (num_issues,
                 _RelativizePath(result_path),
                 _RelativizePath(config_path),
@@ skipping 59 matching lines @@
         build_utils.GetPythonDependencies())
 
   if options.stamp and not rc:
     build_utils.Touch(options.stamp)
 
   return rc
 
 
 if __name__ == '__main__':
   sys.exit(main())