Chromium Code Reviews
Help | Chromium Project | Sign in
(511)

Issue 11899002: Suppress VersionInfoUpdater::OnBootTimes() from ASAN until the bug is fixed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by glotov
Modified:
1 year, 3 months ago
CC:
chromium-reviews_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Suppress VersionInfoUpdater::OnBootTimes() from ASAN until the bug is fixed.

BUG=chromium:170034
TEST=none
TBR=nkostylev
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176898

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : comment #

Messages

Total messages: 11
glotov
Hi!
1 year, 3 months ago #1
Alexander Potapenko
ASan part LGTM once the compilation succeeds on the bots. Note I don't own this ...
1 year, 3 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/13001
1 year, 3 months ago #3
Nikita Kostylev
lgtm https://codereview.chromium.org/11899002/diff/13001/chrome/browser/chromeos/login/version_info_updater.cc File chrome/browser/chromeos/login/version_info_updater.cc (right): https://codereview.chromium.org/11899002/diff/13001/chrome/browser/chromeos/login/version_info_updater.cc#newcode159 chrome/browser/chromeos/login/version_info_updater.cc:159: // ASAN finds bug in the following function: ...
1 year, 3 months ago #4
Nikita Kostylev
On 2013/01/15 13:44:44, Alexander Potapenko wrote: > ASan part LGTM once the compilation succeeds on ...
1 year, 3 months ago #5
Alexander Potapenko
This _is_ the mechanism used to suppress ASan errors on other platforms. It basically just ...
1 year, 3 months ago #6
Nikita Kostylev
Ok, good to know.
1 year, 3 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/27001
1 year, 3 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/27001
1 year, 3 months ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/27001
1 year, 3 months ago #10
I haz the power (commit-bot)
1 year, 3 months ago #11
Message was sent while issue was closed.
Change committed as 176898
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434