Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 11899002: Suppress VersionInfoUpdater::OnBootTimes() from ASAN until the bug is fixed. (Closed)

Created:
7 years, 11 months ago by glotov
Modified:
7 years, 11 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Suppress VersionInfoUpdater::OnBootTimes() from ASAN until the bug is fixed. BUG=chromium:170034 TEST=none TBR=nkostylev NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176898

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/login/version_info_updater.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
glotov
Hi!
7 years, 11 months ago (2013-01-15 13:41:30 UTC) #1
Alexander Potapenko
ASan part LGTM once the compilation succeeds on the bots. Note I don't own this ...
7 years, 11 months ago (2013-01-15 13:44:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/13001
7 years, 11 months ago (2013-01-15 14:02:25 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/11899002/diff/13001/chrome/browser/chromeos/login/version_info_updater.cc File chrome/browser/chromeos/login/version_info_updater.cc (right): https://codereview.chromium.org/11899002/diff/13001/chrome/browser/chromeos/login/version_info_updater.cc#newcode159 chrome/browser/chromeos/login/version_info_updater.cc:159: // ASAN finds bug in the following function: ...
7 years, 11 months ago (2013-01-15 14:02:50 UTC) #4
Nikita (slow)
On 2013/01/15 13:44:44, Alexander Potapenko wrote: > ASan part LGTM once the compilation succeeds on ...
7 years, 11 months ago (2013-01-15 14:05:05 UTC) #5
Alexander Potapenko
This _is_ the mechanism used to suppress ASan errors on other platforms. It basically just ...
7 years, 11 months ago (2013-01-15 14:05:41 UTC) #6
Nikita (slow)
Ok, good to know.
7 years, 11 months ago (2013-01-15 14:07:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/27001
7 years, 11 months ago (2013-01-15 14:15:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/27001
7 years, 11 months ago (2013-01-15 14:16:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11899002/27001
7 years, 11 months ago (2013-01-15 14:24:57 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 14:25:21 UTC) #11
Message was sent while issue was closed.
Change committed as 176898

Powered by Google App Engine
This is Rietveld 408576698