Issue 11896060: Correctly reset lastIndex in an RegExp object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11896060: Correctly reset lastIndex in an RegExp object. (Closed)

Created:
7 years, 11 months ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Correctly reset lastIndex in an RegExp object. R=svenpanne@chromium.org BUG=170856 Committed: https://code.google.com/p/v8/source/detail?r=13471

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
M	src/objects.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+8 lines, -4 lines	1 comment	Download
M	src/runtime.cc	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-170856.js	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 11 months ago (2013-01-23 12:16:12 UTC) #2

LGTM with a nit.

https://codereview.chromium.org/11896060/diff/3001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/11896060/diff/3001/src/objects-inl.h#newcode5018
src/objects-inl.h:5018: ::NONE,
Do we really need to make the top level namespace explicit here?

Expand Messages | Collapse Messages