Correctly reset lastIndex in an RegExp object.

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4991 matching lines @@
   FixedArray* fa = reinterpret_cast<FixedArray*>(data());
   if (value->IsSmi()) {
     fa->set_unchecked(index, Smi::cast(value));
   } else {
     // We only do this during GC, so we don't need to notify the write barrier.
     fa->set_unchecked(heap, index, value, SKIP_WRITE_BARRIER);
   }
 }
 
 
-void JSRegExp::ResetLastIndex() {
-  InObjectPropertyAtPut(JSRegExp::kLastIndexFieldIndex,
-                        Smi::FromInt(0),
-                        SKIP_WRITE_BARRIER);  // It's a Smi.
+void JSRegExp::ResetLastIndex(Isolate* isolate,
+                              Handle<JSRegExp> regexp) {
+  // Reset lastIndex property to 0.
+  SetProperty(regexp,
+              isolate->factory()->last_index_symbol(),
+              Handle<Smi>(Smi::FromInt(0)),
+              ::NONE,

[Sven Panne, 2013/01/23 12:16:12]

Do we really need to make the top level namespace explicit here?

+              kNonStrictMode);
 }
 
 
 ElementsKind JSObject::GetElementsKind() {
   ElementsKind kind = map()->elements_kind();
 #if DEBUG
   FixedArrayBase* fixed_array =
       reinterpret_cast<FixedArrayBase*>(READ_FIELD(this, kElementsOffset));
   Map* map = fixed_array->map();
   ASSERT((IsFastSmiOrObjectElementsKind(kind) &&
@@ skipping 791 matching lines @@
 #undef WRITE_UINT32_FIELD
 #undef READ_SHORT_FIELD
 #undef WRITE_SHORT_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_INL_H_