chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h - Issue 11889003: Fixing ESC in instant-extended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reworked to send ESC down to JS, added test. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h

diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h

index 02245077bf1f90f5cdff7af55d0284dcef5e4b50..bfc0b666af80f6720fccabbaecf364526d6283c1 100644

--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h

+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h

@@ -87,7 +87,8 @@ class OmniboxViewGtk : public OmniboxView,

virtual void ApplyCaretVisibility() OVERRIDE;

virtual void OnTemporaryTextMaybeChanged(

const string16& display_text,

- bool save_original_selection) OVERRIDE;

+ bool save_original_selection,

+ bool notify_text_changed) OVERRIDE;

virtual bool OnInlineAutocompleteTextMaybeChanged(

const string16& display_text, size_t user_text_length) OVERRIDE;

virtual void OnRevertTemporaryText() OVERRIDE;