chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 11889003: Fixing ESC in instant-extended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reworked to send ESC down to JS, added test. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index fbeb402a777c302f81387ff2449a4b741602d156..41f4ca8afcd7ce703d89e927285306418bca38ee 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -522,13 +522,15 @@ void OmniboxViewMac::ApplyTextAttributes(const string16& display_text,

}

void OmniboxViewMac::OnTemporaryTextMaybeChanged(const string16& display_text,

- bool save_original_selection) {

+ bool save_original_selection,

+ bool notify_text_changed) {

if (save_original_selection)

saved_temporary_selection_ = GetSelectedRange();

suggest_text_length_ = 0;

SetWindowTextAndCaretPos(display_text, display_text.size(), false, false);

- model()->OnChanged();

+ if (notify_text_changed)

+ model()->OnChanged();

[field_ clearUndoChain];

}