media: Fix Opus support, and handle bad timestamps correctly in the Opus wrapper.

media/filters/opus_audio_decoder.cc

Index: media/filters/opus_audio_decoder.cc
diff --git a/media/filters/opus_audio_decoder.cc b/media/filters/opus_audio_decoder.cc
index 8837d2c8d935918e6cc3b81c9c1e5883ca965d9c..7e1dd65c49104baae666266c3965366602b0699d 100644
--- a/media/filters/opus_audio_decoder.cc
+++ b/media/filters/opus_audio_decoder.cc
@@ -358,6 +358,7 @@ void OpusAudioDecoder::DoDecodeBuffer(
                << " ts " << input->GetTimestamp().InMicroseconds() << " us"
                << " diff " << diff.InMicroseconds() << " us";
       base::ResetAndReturn(&read_cb_).Run(kDecodeError, NULL);
+      return;

[fbarchard1, 2013/01/15 00:48:36]

I've seen this message before, and it sounds bad but isnt fatal.  This change
makes it fatal.  Should allow the file to be decoded?

[DaleCurtis, 2013/01/15 01:00:29]

We explicitly forbid this behavior since it has lead to weird duration and
playback problems in the past.

[fbarchard1, 2013/01/15 02:26:50]

This behavior still occurs on current/future codecs.  Theres no known work
around?  Stopping playback will cause a larger aberration. 

[Tom Finegan, 2013/01/15 02:44:51]

What do you mean by "a larger aberration"? If this happens in FFmpegAudioDecoder
it does the same thing that OpusAudioDecoder does. I'm just fixing a bug related
to the omission of a single line of code that was missed in the initial review
of this class.

As Dale said, this behavior is explicitly forbidden.

     }
 
     last_input_timestamp_ = input->GetTimestamp();