media: Fix Opus support, and handle bad timestamps correctly in the Opus wrapper.

media/filters/opus_audio_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/opus_audio_decoder.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/message_loop_proxy.h"
@@ skipping 340 matching lines @@
 
   if (!input->IsEndOfStream()) {
     if (last_input_timestamp_ != kNoTimestamp() &&
         input->GetTimestamp() != kNoTimestamp() &&
         input->GetTimestamp() < last_input_timestamp_) {
       base::TimeDelta diff = input->GetTimestamp() - last_input_timestamp_;
       DVLOG(1) << "Input timestamps are not monotonically increasing! "
                << " ts " << input->GetTimestamp().InMicroseconds() << " us"
                << " diff " << diff.InMicroseconds() << " us";
       base::ResetAndReturn(&read_cb_).Run(kDecodeError, NULL);
+      return;

[fbarchard1, 2013/01/15 00:48:36]

I've seen this message before, and it sounds bad but isnt fatal.  This change
makes it fatal.  Should allow the file to be decoded?

[DaleCurtis, 2013/01/15 01:00:29]

We explicitly forbid this behavior since it has lead to weird duration and
playback problems in the past.

[fbarchard1, 2013/01/15 02:26:50]

This behavior still occurs on current/future codecs.  Theres no known work
around?  Stopping playback will cause a larger aberration. 

[Tom Finegan, 2013/01/15 02:44:51]

What do you mean by "a larger aberration"? If this happens in FFmpegAudioDecoder
it does the same thing that OpusAudioDecoder does. I'm just fixing a bug related
to the omission of a single line of code that was missed in the initial review
of this class.

As Dale said, this behavior is explicitly forbidden.

     }
 
     last_input_timestamp_ = input->GetTimestamp();
   }
 
   scoped_refptr<DataBuffer> output_buffer;
 
   if (!Decode(input, false, &output_buffer)) {
     base::ResetAndReturn(&read_cb_).Run(kDecodeError, NULL);
     return;
@@ skipping 181 matching lines @@
 
   // Decoding finished successfully, update statistics.
   PipelineStatistics statistics;
   statistics.audio_bytes_decoded = decoded_audio_size;
   statistics_cb_.Run(statistics);
 
   return true;
 }
 
 }  // namespace media