chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc - Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: nits Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_private_api.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | chrome/browser/ui/webui/about_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

===================================================================

--- chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc (revision 176443)

+++ chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc (working copy)

@@ -378,7 +378,7 @@

localized_strings->SetString("cancel",

l10n_util::GetStringUTF16(IDS_CANCEL));

- ChromeURLDataManager::DataSource::SetFontAndTextDirection(localized_strings);

+ URLDataSource::SetFontAndTextDirection(localized_strings);

SetResult(localized_strings);