Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h" 5 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/json/json_writer.h" 9 #include "base/json/json_writer.h"
10 #include "base/prefs/public/pref_service_base.h" 10 #include "base/prefs/public/pref_service_base.h"
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_RECENT)); 371 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_RECENT));
372 localized_strings->SetString("search", 372 localized_strings->SetString("search",
373 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_SEARCH)); 373 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_SEARCH));
374 localized_strings->SetString("bookmark_all_tabs", 374 localized_strings->SetString("bookmark_all_tabs",
375 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_BOOKMARK_ALL_TABS)); 375 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_BOOKMARK_ALL_TABS));
376 localized_strings->SetString("save", 376 localized_strings->SetString("save",
377 l10n_util::GetStringUTF16(IDS_SAVE)); 377 l10n_util::GetStringUTF16(IDS_SAVE));
378 localized_strings->SetString("cancel", 378 localized_strings->SetString("cancel",
379 l10n_util::GetStringUTF16(IDS_CANCEL)); 379 l10n_util::GetStringUTF16(IDS_CANCEL));
380 380
381 ChromeURLDataManager::DataSource::SetFontAndTextDirection(localized_strings); 381 URLDataSource::SetFontAndTextDirection(localized_strings);
382 382
383 SetResult(localized_strings); 383 SetResult(localized_strings);
384 384
385 // This is needed because unlike the rest of these functions, this class 385 // This is needed because unlike the rest of these functions, this class
386 // inherits from AsyncFunction directly, rather than BookmarkFunction. 386 // inherits from AsyncFunction directly, rather than BookmarkFunction.
387 SendResponse(true); 387 SendResponse(true);
388 388
389 return true; 389 return true;
390 } 390 }
391 391
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 #if defined(OS_WIN) 518 #if defined(OS_WIN)
519 if (win8::IsSingleWindowMetroMode()) 519 if (win8::IsSingleWindowMetroMode())
520 can_open_new_windows = false; 520 can_open_new_windows = false;
521 #endif // OS_WIN 521 #endif // OS_WIN
522 522
523 SetResult(new base::FundamentalValue(can_open_new_windows)); 523 SetResult(new base::FundamentalValue(can_open_new_windows));
524 return true; 524 return true;
525 } 525 }
526 526
527 } // namespace extensions 527 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698