Consolidates lookup of task manager values.

Consolidates lookup of task manager values.

BUG=none
TEST=none
R=estade@chromium.org,ben@chomium.org,dhollowa@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176593

[sky, 2013-01-11 21:45:49]

https://codereview.chromium.org/11885005/diff/1/chrome/browser/ui/gtk/task_ma...
File chrome/browser/ui/gtk/task_manager_gtk.cc (left):

https://codereview.chromium.org/11885005/diff/1/chrome/browser/ui/gtk/task_ma...
chrome/browser/ui/gtk/task_manager_gtk.cc:868: // When sorting by non-grouped
attributes (e.g., Network), just do a normal
Removing this changes the sort behavior on GTK. The old behavior would sort
across groups for some columns where as this won't. Sorting across groups feels
weird as you no longer can easily tell the items in a group. Neither of the
other platforms do this.

[Evan Stade, 2013-01-11 21:56:11]

cool, lgtm

[Evan Stade, 2013-01-11 22:07:45]

https://codereview.chromium.org/11885005/diff/1/chrome/browser/task_manager/t...
File chrome/browser/task_manager/task_manager.h (right):

https://codereview.chromium.org/11885005/diff/1/chrome/browser/task_manager/t...
chrome/browser/task_manager/task_manager.h:308: // Catch all method that calls
off to the appropriate GetResourceXXX method
nit: Garden path sentence. "Catchall" or "Catch-all".

[dhollowa, 2013-01-11 22:43:26]

lgtm

[Ben Goodger (Google), 2013-01-11 23:59:45]

lgtm

[commit-bot: I haz the power, 2013-01-12 00:05:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/11885005/1006

[commit-bot: I haz the power, 2013-01-12 20:16:42]

Change committed as 176593