Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5579)

Unified Diff: chrome/browser/ui/views/task_manager_view.cc

Issue 11885005: Consolidates lookup of task manager values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: garden path Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/task_manager_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/task_manager_view.cc
diff --git a/chrome/browser/ui/views/task_manager_view.cc b/chrome/browser/ui/views/task_manager_view.cc
index 2604e66f498dc9d940ed309ba70d0e31529a48fd..2312109bbf306ddb3c25b0e8e641b939e2d59ee3 100644
--- a/chrome/browser/ui/views/task_manager_view.cc
+++ b/chrome/browser/ui/views/task_manager_view.cc
@@ -100,86 +100,13 @@ int TaskManagerTableModel::RowCount() {
}
string16 TaskManagerTableModel::GetText(int row, int col_id) {
- switch (col_id) {
- case IDS_TASK_MANAGER_TASK_COLUMN: // Process
- return model_->GetResourceTitle(row);
-
- case IDS_TASK_MANAGER_PROFILE_NAME_COLUMN: // Profile Name
- return model_->GetResourceProfileName(row);
-
- case IDS_TASK_MANAGER_NET_COLUMN: // Net
- return model_->GetResourceNetworkUsage(row);
-
- case IDS_TASK_MANAGER_CPU_COLUMN: // CPU
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceCPUUsage(row);
-
- case IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN: // Memory
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourcePrivateMemory(row);
-
- case IDS_TASK_MANAGER_SHARED_MEM_COLUMN: // Memory
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceSharedMemory(row);
-
- case IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN: // Memory
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourcePhysicalMemory(row);
-
- case IDS_TASK_MANAGER_PROCESS_ID_COLUMN:
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceProcessId(row);
-
- case IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN: // Goats Teleported!
- return model_->GetResourceGoatsTeleported(row);
-
- case IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN:
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceWebCoreImageCacheSize(row);
-
- case IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN:
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceWebCoreScriptsCacheSize(row);
-
- case IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN:
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceWebCoreCSSCacheSize(row);
-
- case IDS_TASK_MANAGER_FPS_COLUMN:
- return model_->GetResourceFPS(row);
-
- case IDS_TASK_MANAGER_VIDEO_MEMORY_COLUMN:
- return model_->GetResourceVideoMemory(row);
-
- case IDS_TASK_MANAGER_SQLITE_MEMORY_USED_COLUMN:
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceSqliteMemoryUsed(row);
-
- case IDS_TASK_MANAGER_JAVASCRIPT_MEMORY_ALLOCATED_COLUMN:
- if (!model_->IsResourceFirstInGroup(row))
- return string16();
- return model_->GetResourceV8MemoryAllocatedSize(row);
-
- default:
- NOTREACHED();
- return string16();
- }
+ return model_->GetResourceById(row, col_id);
}
gfx::ImageSkia TaskManagerTableModel::GetIcon(int row) {
return model_->GetResourceIcon(row);
}
-
void TaskManagerTableModel::GetGroupRangeForItem(int item,
views::GroupRange* range) {
TaskManagerModel::GroupRange range_pair =
« no previous file with comments | « chrome/browser/ui/gtk/task_manager_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698