Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2071)

Unified Diff: device/bluetooth/bluetooth_service_record.h

Issue 11884027: Separated BluetoothServiceRecord interface from BluetoothServiceRecordChromeOs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changed namespace from device to chromeos. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_service_record.h
diff --git a/device/bluetooth/bluetooth_service_record.h b/device/bluetooth/bluetooth_service_record.h
index e04d73a632f86fa4be5bcbbc9f494f7ae2bf03f4..5059776abc37b98cce551823639a429b83ceeb2f 100644
--- a/device/bluetooth/bluetooth_service_record.h
+++ b/device/bluetooth/bluetooth_service_record.h
@@ -9,8 +9,6 @@
#include "base/basictypes.h"
-class XmlReader;
-
namespace device {
// BluetoothServiceRecord represents an SDP service record.
@@ -19,30 +17,27 @@ namespace device {
// that have been necessary so far.
class BluetoothServiceRecord {
public:
- BluetoothServiceRecord(
- const std::string& address,
- const std::string& xml_data);
+ virtual ~BluetoothServiceRecord();
- // The human-readable name of this service.
- const std::string& name() const { return name_; }
+ // The human-readable name of this service.
+ const std::string& name() const { return name_; }
- // The address of the BluetoothDevice providing this service.
- const std::string& address() const { return address_; }
+ // The address of the BluetoothDevice providing this service.
+ const std::string& address() const { return address_; }
- // The UUID of the service. This field may be empty if no UUID was
- // specified in the service record.
- const std::string& uuid() const { return uuid_; }
+ // The UUID of the service. This field may be empty if no UUID was
+ // specified in the service record.
+ const std::string& uuid() const { return uuid_; }
- // Indicates if this service supports RFCOMM communication.
- bool SupportsRfcomm() const { return supports_rfcomm_; }
+ // Indicates if this service supports RFCOMM communication.
+ bool SupportsRfcomm() const { return supports_rfcomm_; }
- // The RFCOMM channel to use, if this service supports RFCOMM communication.
- // The return value is undefined if SupportsRfcomm() returns false.
- uint8 rfcomm_channel() const { return rfcomm_channel_; }
+ // The RFCOMM channel to use, if this service supports RFCOMM communication.
+ // The return value is undefined if SupportsRfcomm() returns false.
+ uint8 rfcomm_channel() const { return rfcomm_channel_; }
- private:
- void ExtractChannels(XmlReader* reader);
- void ExtractUuid(XmlReader* reader);
+ protected:
+ BluetoothServiceRecord();
std::string address_;
std::string name_;
@@ -51,6 +46,7 @@ class BluetoothServiceRecord {
bool supports_rfcomm_;
uint8 rfcomm_channel_;
+ private:
DISALLOW_COPY_AND_ASSIGN(BluetoothServiceRecord);
};

Powered by Google App Engine
This is Rietveld 408576698