Separated BluetoothServiceRecord interface from BluetoothServiceRecordChromeOs.

device/bluetooth/bluetooth_service_record_chromeos.h

Index: device/bluetooth/bluetooth_service_record_chromeos.h
diff --git a/device/bluetooth/bluetooth_service_record_chromeos.h b/device/bluetooth/bluetooth_service_record_chromeos.h
new file mode 100644
index 0000000000000000000000000000000000000000..04f2b3aa7a9f8bcc95753e264d3ef21a433ff9d8
--- /dev/null
+++ b/device/bluetooth/bluetooth_service_record_chromeos.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_BLUETOOTH_BLUETOOTH_SERVICE_RECORD_CHROMEOS_H_
+#define DEVICE_BLUETOOTH_BLUETOOTH_SERVICE_RECORD_CHROMEOS_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "device/bluetooth/bluetooth_service_record.h"
+
+class XmlReader;
+
+namespace chromeos {

[tfarina, 2013/01/15 17:08:13]

shouldn't this be in device namespace? this is under device/bluetooth/
directory.

[youngki, 2013/01/15 17:18:31]

All other *_chromeos.* in device use chromeos namespace; I think it was decided
in https://chromiumcodereview.appspot.com/10899037/ that we stay with chromeos
namespace for chromeos files in device directory. I'd rather go with consistency
rather than changing this to device namespace.

[tfarina, 2013/01/15 17:23:04]

This is not following any convention. This is crazy. We don't choose the
namespace based on file sufix. Namespaces should be picked upon directory path.
Yep, but keep that in mind for future. May be file a clean up bug at crbug.com/
to sort this out in a follow up CL?

+
+// BluetoothServiceRecordChromeOs is an implementation of BluetoothServiceRecord
+// for the ChromeOS platform.
+class BluetoothServiceRecordChromeOs : public device::BluetoothServiceRecord {

[tfarina, 2013/01/15 17:08:13]

ChromeOs is too weird. ChromeOS seems better.

[youngki, 2013/01/15 17:18:31]

Again, all other classes in device directory use ChromeOs; we could change all
those names to ChromeOS, but I don't think it's worth it in this CL, so I am
leaving it as ChromeOs.

[tfarina, 2013/01/15 17:23:04]

Not in this CL of course, but could be done in a follow up CL and get a bug
filed at crbug.com, so it is not missed.

+ public:
+  BluetoothServiceRecordChromeOs(
+      const std::string& address,

[tfarina, 2013/01/15 17:08:13]

doesn't this fit above?

[youngki, 2013/01/15 17:18:31]

Done.

+      const std::string& xml_data);
+
+ private:
+  void ExtractChannels(XmlReader* reader);
+  void ExtractUuid(XmlReader* reader);
+
+  DISALLOW_COPY_AND_ASSIGN(BluetoothServiceRecordChromeOs);
+};
+
+}  // namespace chromeos
+
+#endif  // DEVICE_BLUETOOTH_BLUETOOTH_SERVICE_RECORD_CHROMEOS_H_