Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: cc/layer_impl.h

Issue 11882037: Activate LayerImpl tree with sync+push instead of pointer swap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layer.cc ('k') | cc/layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_impl.h
diff --git a/cc/layer_impl.h b/cc/layer_impl.h
index 3c8c04080ad30e68de214e65cba380fbafb0a4b2..c05fb5539017b73a4b69a4cc12b6e115325f61da 100644
--- a/cc/layer_impl.h
+++ b/cc/layer_impl.h
@@ -67,17 +67,23 @@ public:
LayerImpl* parent() { return m_parent; }
const LayerImpl* parent() const { return m_parent; }
const LayerList& children() const { return m_children; }
+ LayerList& children() { return m_children; }
+ LayerImpl* childAt(size_t index) const;
void addChild(scoped_ptr<LayerImpl>);
scoped_ptr<LayerImpl> removeChild(LayerImpl* child);
void removeAllChildren();
+ void setParent(LayerImpl* parent) { m_parent = parent; }
+ void clearChildList(); // Warning: This does not preserve tree structure invariants.
void setMaskLayer(scoped_ptr<LayerImpl>);
LayerImpl* maskLayer() { return m_maskLayer.get(); }
const LayerImpl* maskLayer() const { return m_maskLayer.get(); }
+ scoped_ptr<LayerImpl> takeMaskLayer();
void setReplicaLayer(scoped_ptr<LayerImpl>);
LayerImpl* replicaLayer() { return m_replicaLayer.get(); }
const LayerImpl* replicaLayer() const { return m_replicaLayer.get(); }
+ scoped_ptr<LayerImpl> takeReplicaLayer();
bool hasMask() const { return m_maskLayer; }
bool hasReplica() const { return m_replicaLayer; }
@@ -101,6 +107,8 @@ public:
virtual RenderPass::Id firstContributingRenderPassId() const;
virtual RenderPass::Id nextContributingRenderPassId(RenderPass::Id) const;
+ virtual ScrollbarLayerImpl* toScrollbarLayer();
+
// Returns true if this layer has content to draw.
void setDrawsContent(bool);
bool drawsContent() const { return m_drawsContent; }
@@ -296,6 +304,9 @@ public:
virtual bool areVisibleResourcesReady() const;
+ virtual scoped_ptr<LayerImpl> createLayerImpl(LayerTreeImpl*);
+ virtual void pushPropertiesTo(LayerImpl*);
+
protected:
LayerImpl(LayerTreeImpl* layerImpl, int);
@@ -308,13 +319,6 @@ protected:
static std::string indentString(int indent);
private:
- scoped_ptr<LayerImpl> takeMaskLayer();
- scoped_ptr<LayerImpl> takeReplicaLayer();
-
- void setParent(LayerImpl* parent) { m_parent = parent; }
- friend class TreeSynchronizer;
- void clearChildList(); // Warning: This does not preserve tree structure invariants and so is only exposed to the tree synchronizer.
-
void updateScrollbarPositions();
void noteLayerSurfacePropertyChanged();
@@ -350,6 +354,7 @@ private:
Region m_nonFastScrollableRegion;
Region m_touchEventHandlerRegion;
SkColor m_backgroundColor;
+ bool m_stackingOrderChanged;
// Whether the "back" of this layer should draw.
bool m_doubleSided;
« no previous file with comments | « cc/layer.cc ('k') | cc/layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698