Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 11880040: Fix pylint presubmit checks (Closed)

Created:
7 years, 11 months ago by Isaac (away)
Modified:
7 years, 11 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Visibility:
Public.

Description

Fix pylint presubmit checks pylint checks were erronously excluded for PRESUBMIT.py files in root directory of repos because the regex was getting a './' added. R=iannucci@chromium.org TBR=M-A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=176777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M presubmit_canned_checks.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
lgtm
7 years, 11 months ago (2013-01-15 03:11:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11880040/1
7 years, 11 months ago (2013-01-15 03:13:40 UTC) #2
commit-bot: I haz the power
Presubmit check for 11880040-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-15 03:16:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11880040/1
7 years, 11 months ago (2013-01-15 03:19:36 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 03:22:05 UTC) #5
Message was sent while issue was closed.
Change committed as 176777

Powered by Google App Engine
This is Rietveld 408576698