presubmit_canned_checks.py - Issue 11880040: Fix pylint presubmit checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 11880040: Fix pylint presubmit checks (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools@master

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 1e0d4c1729597e9c9deb40cc73a0d41801e7da22..90c79ccfcc6deda18a16bed8dfdc65d4848579e4 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -643,6 +643,9 @@ def RunPylint(input_api, output_api, white_list=None, black_list=None,

# Only trigger if there is at least one python file affected.

def rel_path(regex):

"""Modifies a regex for a subject to accept paths relative to root."""

+ if input_api.os_path.samefile(

+ input_api.PresubmitLocalPath(), input_api.change.RepositoryRoot()):

+ return regex

prefix = input_api.os_path.join(input_api.os_path.relpath(

input_api.PresubmitLocalPath(), input_api.change.RepositoryRoot()), '')

return input_api.re.escape(prefix) + regex

« no previous file with comments | « no previous file | no next file » | no next file with comments »