FileBrowserHandlerManifestTest.FileManagerURLOverride test fails on Chromeium OS valgrind bot

FileBrowserHandlerManifestTest.FileManagerURLOverride test fails on Chromeium OS valgrind bot

Register ManifestHandler for chrome_url_overrides before running the test.

Patch from Joe Thomas <mhx348@motorola.com>;.

BUG=159265, 169823
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176843

[Joe Thomas, 2013-01-14 18:49:36]

Please review.

[Joe Thomas, 2013-01-14 18:55:24]

Should we file a bug against linux_chromeos bot for not failing this test before
landing the patch? I can see this test passed in
https://codereview.chromium.org/11660016/. But failing for me locally.

[Yoyo Zhou, 2013-01-14 19:07:14]

LGTM.
Are you seeing both of failures (that Brad reported) locally? If you don't have
try bot access, I can send this to the valgrind trybots for you.

[Joe Thomas, 2013-01-14 19:26:07]

On 2013/01/14 19:07:14, Yoyo Zhou wrote:
> LGTM.
> Are you seeing both of failures (that Brad reported) locally? If you don't
have
> try bot access, I can send this to the valgrind trybots for you.

I was able to reproduce the unittest failure that Brad reported locally. So I
was wondering why it was not captured by linux_chromeos bot in
https://codereview.chromium.org/11660016/(CL for chrome_url_overrides parsing)
before landing the patch.

With this CL, the issue is no more reproducible locally. So I think we can
safely assume that the issue is fixed now on valgrind bots also.

I don't have trybot access. Could you please send this to CL valgrind trybot?

[Yoyo Zhou, 2013-01-14 19:28:19]

On 2013/01/14 19:26:07, Joe Thomas wrote:
> On 2013/01/14 19:07:14, Yoyo Zhou wrote:
> > LGTM.
> > Are you seeing both of failures (that Brad reported) locally? If you don't
> have
> > try bot access, I can send this to the valgrind trybots for you.
> 
> I was able to reproduce the unittest failure that Brad reported locally. So I
> was wondering why it was not captured by linux_chromeos bot in
> https://codereview.chromium.org/11660016/%28CL for chrome_url_overrides
parsing)
> before landing the patch.
> 
> With this CL, the issue is no more reproducible locally. So I think we can
> safely assume that the issue is fixed now on valgrind bots also.
> 
> I don't have trybot access. Could you please send this to CL valgrind trybot?

Ah, it looks like the "Try more bots" link in the code review will do it. I
checked all of the linux_chromeos boxes.

[Joe Thomas, 2013-01-14 19:30:28]

> > I don't have trybot access. Could you please send this CL to valgrind
trybot?
> 
> Ah, it looks like the "Try more bots" link in the code review will do it. I
> checked all of the linux_chromeos boxes.

Thanks!

[Joe Thomas, 2013-01-14 19:55:30]

The trybot builds failed as it failed to apply the patch. I thought it could be
a rebasing issue but does not look like one. I created the patch again. Could
you please try adding the bots?

[Yoyo Zhou, 2013-01-14 19:59:58]

On 2013/01/14 19:55:30, Joe Thomas wrote:
> The trybot builds failed as it failed to apply the patch. I thought it could
be
> a rebasing issue but does not look like one. I created the patch again. Could
> you please try adding the bots?

You should be able to Try more bots. Let me know if it doesn't work for you
though.

[Yoyo Zhou, 2013-01-14 20:00:41]

On 2013/01/14 19:59:58, Yoyo Zhou wrote:
> On 2013/01/14 19:55:30, Joe Thomas wrote:
> > The trybot builds failed as it failed to apply the patch. I thought it could
> be
> > a rebasing issue but does not look like one. I created the patch again.
Could
> > you please try adding the bots?
> 
> You should be able to Try more bots. Let me know if it doesn't work for you
> though.

Oh, I think it's because it's attempting to patch on top of LKGR, which is
behind the exclusion. Let me see if there's a workaround.

[Yoyo Zhou, 2013-01-14 20:15:15]

I manually sent new try jobs for you, but accidentally left the default set of
try bots selected. Sorry about the spam! Just look for the
linux_chromeos_valgrind and linux_chromeos_asan in particular.

[Joe Thomas, 2013-01-14 20:52:19]

On 2013/01/14 20:15:15, Yoyo Zhou wrote:
> I manually sent new try jobs for you, but accidentally left the default set of
> try bots selected. Sorry about the spam! Just look for the
> linux_chromeos_valgrind and linux_chromeos_asan in particular.

Both the trybot builds failed at "update". 

I think it's safe to commit the change as the unittest is passing locally with
this CL. The test was failing locally with the same error as in valgrind bot.

[Yoyo Zhou, 2013-01-14 20:55:43]

On 2013/01/14 20:52:19, Joe Thomas wrote:
> On 2013/01/14 20:15:15, Yoyo Zhou wrote:
> > I manually sent new try jobs for you, but accidentally left the default set
of
> > try bots selected. Sorry about the spam! Just look for the
> > linux_chromeos_valgrind and linux_chromeos_asan in particular.
> 
> Both the trybot builds failed at "update". 
> 
> I think it's safe to commit the change as the unittest is passing locally with
> this CL. The test was failing locally with the same error as in valgrind bot.

Ok, let's go for it.

[commit-bot: I haz the power, 2013-01-14 20:58:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11880029/8001

[commit-bot: I haz the power, 2013-01-15 00:20:48]

Retried try job too often on win_rel for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-15 00:30:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11880029/8001

[commit-bot: I haz the power, 2013-01-15 07:11:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11880029/8001

[commit-bot: I haz the power, 2013-01-15 08:10:31]

Change committed as 176843