build/android/pylib/valgrind_tools.py - Issue 11876021: Support startup performance tests on Galaxy S3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/valgrind_tools.py

Issue 11876021: Support startup performance tests on Galaxy S3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Support startup performance tests on Galaxy S3 - code review fixes Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/valgrind_tools.py

diff --git a/build/android/pylib/valgrind_tools.py b/build/android/pylib/valgrind_tools.py

index 1fb97dc61b1125dfb54a9314de5c3e6ed1d9a3c0..48a5ba73d46e924a8f6b7ab6ff6788a0ec873484 100644

--- a/build/android/pylib/valgrind_tools.py

+++ b/build/android/pylib/valgrind_tools.py

@@ -35,7 +35,7 @@ def SetChromeTimeoutScale(adb, scale):

# Delete if scale is None/0.0/1.0 since the default timeout scale is 1.0

adb.RunShellCommand('rm %s' % path)

else:

- adb.SetFileContents(path, '%f' % scale)

+ adb.SetProtectedFileContents(path, '%f' % scale)

class BaseTool(object):