build/android/pylib/flag_changer.py - Issue 11876021: Support startup performance tests on Galaxy S3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/flag_changer.py

Issue 11876021: Support startup performance tests on Galaxy S3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Support startup performance tests on Galaxy S3 - code review fixes Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/flag_changer.py

diff --git a/build/android/pylib/flag_changer.py b/build/android/pylib/flag_changer.py

index 8b8dbca59055f4a4c7ac1005fd95669ef599dd11..d497ef6fdfd752b0caf264baec13d3ae7516950d 100644

--- a/build/android/pylib/flag_changer.py

+++ b/build/android/pylib/flag_changer.py

@@ -89,11 +89,11 @@ class FlagChanger(object):

print "Current flags: ", self._current_flags

if self._current_flags:

- self._android_cmd.SetFileContents(CHROME_COMMAND_FILE,

+ self._android_cmd.SetProtectedFileContents(CHROME_COMMAND_FILE,

frankf 2013/01/17 18:45:39 alignment.

'chrome ' +

' '.join(self._current_flags))

else:

- self._android_cmd.RunShellCommand('rm ' + CHROME_COMMAND_FILE)

+ self._android_cmd.RunShellCommand('su -c rm ' + CHROME_COMMAND_FILE)

def _TokenizeFlags(self, line):

"""Changes the string containing the command line into a list of flags.