Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 11875017: [Telemetry] fix google_credentials_backend_unittest.py and facebook_credentials_backend_unittest.py. (Closed)

Created:
7 years, 11 months ago by hartmanng
Modified:
7 years, 11 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] fix google_credentials_backend_unittest.py and facebook_credentials_backend_unittest.py. The mentioned files both have flaky tests called testRealLoginWithDontOverrideProfileIfPossible. This should fix them. BUG=169447 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177266

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -198 lines) Patch
M tools/telemetry/telemetry/browser_credentials.py View 1 2 chunks +14 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/facebook_credentials_backend_unittest.py View 1 1 chunk +11 lines, -89 lines 0 comments Download
M tools/telemetry/telemetry/form_based_credentials_backend.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py View 1 5 chunks +46 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/google_credentials_backend_unittest.py View 1 1 chunk +10 lines, -88 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nduca
message: The only real clean option I see here if you restart the browser is ...
7 years, 11 months ago (2013-01-14 20:59:27 UTC) #1
hartmanng
> What about forcing the browser_credentials system to think that needs to login > again? ...
7 years, 11 months ago (2013-01-15 18:59:51 UTC) #2
nduca
seems cool. lgtm but I didn't really exhaustively review. Can you get dtu to give ...
7 years, 11 months ago (2013-01-16 03:02:07 UTC) #3
hartmanng
On 2013/01/16 03:02:07, nduca wrote: > seems cool. lgtm but I didn't really exhaustively review. ...
7 years, 11 months ago (2013-01-16 14:09:58 UTC) #4
dtu
lgtm
7 years, 11 months ago (2013-01-16 20:22:56 UTC) #5
hartmanng
thanks!
7 years, 11 months ago (2013-01-16 20:28:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11875017/2001
7 years, 11 months ago (2013-01-16 20:30:18 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 23:36:53 UTC) #8
Message was sent while issue was closed.
Change committed as 177266

Powered by Google App Engine
This is Rietveld 408576698