Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/google_credentials_backend_unittest.py

Issue 11875017: [Telemetry] fix google_credentials_backend_unittest.py and facebook_credentials_backend_unittest.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/google_credentials_backend_unittest.py
diff --git a/tools/telemetry/telemetry/google_credentials_backend_unittest.py b/tools/telemetry/telemetry/google_credentials_backend_unittest.py
index f5dd7538d2e52c86064bfea5df95917b05ca085d..5d5cfb3f34d4582bf9dc600bb83d966d88c97dd3 100644
--- a/tools/telemetry/telemetry/google_credentials_backend_unittest.py
+++ b/tools/telemetry/telemetry/google_credentials_backend_unittest.py
@@ -1,94 +1,16 @@
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import os
-import unittest
-
-from telemetry import browser_finder
+from telemetry import form_based_credentials_backend_unittest_base
from telemetry import google_credentials_backend
-from telemetry import simple_mock
-from telemetry import options_for_unittests
-
-_ = simple_mock.DONT_CARE
-
-class MockTab(simple_mock.MockObject):
- def __init__(self):
- super(MockTab, self).__init__()
- self.runtime = simple_mock.MockObject(self)
- self.page = simple_mock.MockObject(self)
-
-class TestGoogleCredentialsBackend(unittest.TestCase):
- def testRealLoginIfPossible(self):
- credentials_path = os.path.join(
- os.path.dirname(__file__),
- '..', '..', 'perf', 'data', 'credentials.json')
- if not os.path.exists(credentials_path):
- return
-
- options = options_for_unittests.GetCopy()
- with browser_finder.FindBrowser(options).Create() as b:
- b.credentials.credentials_path = credentials_path
- if not b.credentials.CanLogin('google'):
- return
- ret = b.credentials.LoginNeeded(b.tabs[0], 'google')
- self.assertTrue(ret)
-
- def testRealLoginWithDontOverrideProfileIfPossible(self):
- credentials_path = os.path.join(
- os.path.dirname(__file__),
- '..', '..', 'perf', 'data', 'credentials.json')
- if not os.path.exists(credentials_path):
- return
-
- options = options_for_unittests.GetCopy()
- options.dont_override_profile = True
-
- # Login once to make sure our default profile is logged in.
- with browser_finder.FindBrowser(options).Create() as b:
- b.credentials.credentials_path = credentials_path
- if not b.credentials.CanLogin('google'):
- return
- ret = b.credentials.LoginNeeded(b.tabs[0], 'google')
- self.assertTrue(ret)
-
- # Second time will test that we behave correctly if we're logged in,
- # but our b.credentials doesn't know yet.
- with browser_finder.FindBrowser(options).Create() as b:
- b.credentials.credentials_path = credentials_path
- if not b.credentials.CanLogin('google'):
- return
- ret = b.credentials.LoginNeeded(b.tabs[0], 'google')
- self.assertTrue(ret)
-
- def testLoginUsingMock(self): # pylint: disable=R0201
- tab = MockTab()
-
- backend = google_credentials_backend.GoogleCredentialsBackend()
- config = {'username': 'blah',
- 'password': 'blargh'}
-
- tab.page.ExpectCall('Navigate', 'https://accounts.google.com/')
- tab.runtime.ExpectCall('Evaluate', _).WillReturn(False)
- tab.runtime.ExpectCall('Evaluate', _).WillReturn(True)
- tab.runtime.ExpectCall('Evaluate', _).WillReturn(False)
- tab.ExpectCall('WaitForDocumentReadyStateToBeInteractiveOrBetter')
-
- def VerifyEmail(js):
- assert 'Email' in js
- assert 'blah' in js
- tab.runtime.ExpectCall('Execute', _).WhenCalled(VerifyEmail)
-
- def VerifyPw(js):
- assert 'Passwd' in js
- assert 'largh' in js
- tab.runtime.ExpectCall('Execute', _).WhenCalled(VerifyPw)
-
- def VerifySubmit(js):
- assert '.submit' in js
- tab.runtime.ExpectCall('Execute', _).WhenCalled(VerifySubmit)
-
- # Checking for form still up.
- tab.runtime.ExpectCall('Evaluate', _).WillReturn(False)
- backend.LoginNeeded(tab, config)
+class TestGoogleCredentialsBackend(
+ form_based_credentials_backend_unittest_base.
+ FormBasedCredentialsBackendUnitTestBase):
+ def setUp(self):
+ self._credentials_type = 'google'
+ def testLoginUsingMock(self):
+ self._LoginUsingMock(google_credentials_backend.GoogleCredentialsBackend(),
+ 'https://accounts.google.com/', 'Email',
+ 'Passwd')
« no previous file with comments | « tools/telemetry/telemetry/form_based_credentials_backend_unittest_base.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698