cc: Stop using drawableContentRect for occlusion.

cc: Stop using drawableContentRect for occlusion.

The occlusion tracker has been using the drawableContentRect() which is not
useful compared to the clipRect() unless queries go outside the bounds of
the layer (which they would not). Also, the tests would override and fake
out the layer drawableContentRect() instead of just making a clipRect()
with an appropriate tree hierarchy.

The unit tests are now more real, and set up clipping in legitimite ways,
and drawableContentRect() is no longer used.

This removes most of the usage of the drawableContentRect() outside of tests,
making it easier to remove it entirely in the future if we like.

Tested by all the occlusion tracker unit tests in cc_unittests.

TBR=cdn@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177974

[enne (OOO), 2013-01-20 23:34:27]

https://codereview.chromium.org/11871008/diff/5001/cc/occlusion_tracker_unitt...
File cc/occlusion_tracker_unittest.cc (right):

https://codereview.chromium.org/11871008/diff/5001/cc/occlusion_tracker_unitt...
cc/occlusion_tracker_unittest.cc:493: EXPECT_RECT_EQ(gfx::Rect(31, 29, 69, 1),
occlusion.unoccludedLayerContentRect(parent, gfx::Rect(31, 29, 70, 70)));
Looking at the previous checks, I understand how this is right *now*, but how
was this right before?

[danakj, 2013-01-20 23:36:05]

https://codereview.chromium.org/11871008/diff/5001/cc/occlusion_tracker_unitt...
File cc/occlusion_tracker_unittest.cc (right):

https://codereview.chromium.org/11871008/diff/5001/cc/occlusion_tracker_unitt...
cc/occlusion_tracker_unittest.cc:493: EXPECT_RECT_EQ(gfx::Rect(31, 29, 69, 1),
occlusion.unoccludedLayerContentRect(parent, gfx::Rect(31, 29, 70, 70)));
On 2013/01/20 23:34:27, enne wrote:
> Looking at the previous checks, I understand how this is right *now*, but how
> was this right before?

It was right before because it was not clipping, so it was seeing the row of
pixels at 29y and the column of pixels at 31+70x.

[enne (OOO), 2013-01-21 00:53:18]

lgtm

[commit-bot: I haz the power, 2013-01-21 00:57:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11871008/2002

[commit-bot: I haz the power, 2013-01-21 00:57:06]

Failed to apply patch for cc/delegated_renderer_layer_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/delegated_renderer_layer_impl.cc
  Hunk #1 FAILED at 146.
  1 out of 1 hunk FAILED -- saving rejects to file
cc/delegated_renderer_layer_impl.cc.rej

Patch:       cc/delegated_renderer_layer_impl.cc
Index: cc/delegated_renderer_layer_impl.cc
diff --git a/cc/delegated_renderer_layer_impl.cc
b/cc/delegated_renderer_layer_impl.cc
index
e2c3739c3373731bd1b3b2f19562b397d3b89b25..f6357c75332297535dc2e9d6b1f640bafbc20aa3
100644
--- a/cc/delegated_renderer_layer_impl.cc
+++ b/cc/delegated_renderer_layer_impl.cc
@@ -146,7 +146,6 @@ void
DelegatedRendererLayerImpl::appendRenderPassQuads(QuadSink& quadSink, Appen
               DCHECK(renderTarget() != this);
 
               copiedSharedQuadState->content_to_target_transform =
drawTransform() * copiedSharedQuadState->content_to_target_transform;
-              copiedSharedQuadState->clipped_rect_in_target =
MathUtil::mapClippedRect(drawTransform(),
copiedSharedQuadState->clipped_rect_in_target);
               copiedSharedQuadState->clip_rect =
MathUtil::mapClippedRect(drawTransform(), copiedSharedQuadState->clip_rect);
               copiedSharedQuadState->opacity *= drawOpacity();
             }

[commit-bot: I haz the power, 2013-01-22 01:27:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11871008/14001

[commit-bot: I haz the power, 2013-01-22 01:28:16]

Presubmit check for 11871008-14001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common/cc_messages.h
    content/common

Presubmit checks took 5.4s to calculate.

[danakj, 2013-01-22 01:30:12]

+cdn@chromium.org for cc_messages. TBR'ing as I'm just removing a field.

[commit-bot: I haz the power, 2013-01-22 01:30:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11871008/14001

[commit-bot: I haz the power, 2013-01-22 03:43:04]

Change committed as 177974