Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3343)

Unified Diff: cc/render_surface_impl.cc

Issue 11871008: cc: Stop using drawableContentRect for occlusion. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/render_pass_unittest.cc ('k') | cc/shared_quad_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/render_surface_impl.cc
diff --git a/cc/render_surface_impl.cc b/cc/render_surface_impl.cc
index 84758da0932cdcb9aa07542a623d76eae81147ea..05d19a45685564d97c1f59019464a2b18b05473f 100644
--- a/cc/render_surface_impl.cc
+++ b/cc/render_surface_impl.cc
@@ -150,27 +150,6 @@ void RenderSurfaceImpl::clearLayerLists()
m_contributingDelegatedRenderPassLayerList.clear();
}
-static inline gfx::Rect computeClippedRectInTarget(const LayerImpl* owningLayer)
-{
- DCHECK(owningLayer->parent());
-
- const LayerImpl* renderTarget = owningLayer->parent()->renderTarget();
- const RenderSurfaceImpl* self = owningLayer->renderSurface();
-
- gfx::Rect clippedRectInTarget = self->clipRect();
- if (owningLayer->backgroundFilters().hasFilterThatMovesPixels()) {
- // If the layer has background filters that move pixels, we cannot scissor as tightly.
- // FIXME: this should be able to be a tighter scissor, perhaps expanded by the filter outsets?
- clippedRectInTarget = renderTarget->renderSurface()->contentRect();
- } else if (clippedRectInTarget.IsEmpty()) {
- // For surfaces, empty clipRect means that the surface does not clip anything.
- clippedRectInTarget = renderTarget->renderSurface()->contentRect();
- clippedRectInTarget.Intersect(gfx::ToEnclosingRect(self->drawableContentRect()));
- } else
- clippedRectInTarget.Intersect(gfx::ToEnclosingRect(self->drawableContentRect()));
- return clippedRectInTarget;
-}
-
RenderPass::Id RenderSurfaceImpl::renderPassId()
{
int layerId = m_owningLayer->id();
@@ -193,10 +172,9 @@ void RenderSurfaceImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& appendQ
{
DCHECK(!forReplica || m_owningLayer->hasReplica());
- gfx::Rect clippedRectInTarget = computeClippedRectInTarget(m_owningLayer);
const gfx::Transform& drawTransform = forReplica ? m_replicaDrawTransform : m_drawTransform;
SharedQuadState* sharedQuadState = quadSink.useSharedQuadState(SharedQuadState::Create());
- sharedQuadState->SetAll(drawTransform, m_contentRect, clippedRectInTarget, m_clipRect, m_isClipped, m_drawOpacity);
+ sharedQuadState->SetAll(drawTransform, m_contentRect, m_clipRect, m_isClipped, m_drawOpacity);
if (m_owningLayer->showDebugBorders()) {
SkColor color = forReplica ? DebugColors::SurfaceReplicaBorderColor() : DebugColors::SurfaceBorderColor();
« no previous file with comments | « cc/render_pass_unittest.cc ('k') | cc/shared_quad_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698