Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: chrome/browser/autofill/form_structure.h

Issue 11867025: Download autocheckout whitelist and enable autocheckout for whitelisted sites only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert code change for manual testing/:wq. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/form_structure.h
diff --git a/chrome/browser/autofill/form_structure.h b/chrome/browser/autofill/form_structure.h
index 118dc5df9443acfbff483dfbbe4dc3e6cee4d3d0..37fe3df4ed641c79e0fe022978bcb630c7421565 100644
--- a/chrome/browser/autofill/form_structure.h
+++ b/chrome/browser/autofill/form_structure.h
@@ -44,6 +44,7 @@ class XmlElement;
class FormStructure {
public:
explicit FormStructure(const FormData& form);
+ FormStructure(const FormData& form, bool autocheckout_enabled);
Ilya Sherman 2013/01/24 22:01:55 Please replace the previous constructor, rather th
benquan 2013/01/25 00:55:31 I was told we do not want default value for parame
Ilya Sherman 2013/01/25 01:22:40 Yes, that's correct: parameters should not have de
virtual ~FormStructure();
// Runs several heuristics against the form fields to determine their possible
@@ -164,6 +165,10 @@ class FormStructure {
private:
friend class FormStructureTest;
FRIEND_TEST_ALL_PREFIXES(AutofillDownloadTest, QueryAndUploadTest);
+
+ // Initialize FormStructure object, called by constructors.
+ void Init(const FormData& form);
+
// 64-bit hash of the string - used in FormSignature and unit-tests.
static std::string Hash64Bit(const std::string& str);
@@ -232,8 +237,9 @@ class FormStructure {
// author, via the |autocompletetype| attribute.
bool has_author_specified_types_;
- // State of the kEnableExperimentalFormFilling flag.
- bool experimental_form_filling_enabled_;
+ // Whether the autocheckout feature is enabled for the site which contains
+ // this form.
+ bool autocheckout_enabled_;
DISALLOW_COPY_AND_ASSIGN(FormStructure);
};

Powered by Google App Engine
This is Rietveld 408576698