Download autocheckout whitelist and enable autocheckout for whitelisted sites only.

chrome/browser/autofill/form_structure.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 #define CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 26 matching lines @@
 
 namespace buzz {
 class XmlElement;
 }
 
 // FormStructure stores a single HTML form together with the values entered
 // in the fields along with additional information needed by Autofill.
 class FormStructure {
  public:
   explicit FormStructure(const FormData& form);
+  FormStructure(const FormData& form, bool autocheckout_enabled);

[Ilya Sherman, 2013/01/24 22:01:55]

Please replace the previous constructor, rather than adding a new one.

[benquan, 2013/01/25 00:55:31]

I was told we do not want default value for parameters. Do you think it is ok?

On 2013/01/24 22:01:55, Ilya Sherman wrote:

[Ilya Sherman, 2013/01/25 01:22:40]

Yes, that's correct: parameters should not have default values.  By overloading
the constructor, you're essentially providing a default value.  Hence, you
shouldn't overload the constructor.

On 2013/01/25 00:55:31, benquan wrote:

   virtual ~FormStructure();
 
   // Runs several heuristics against the form fields to determine their possible
   // types.
   void DetermineHeuristicTypes(const AutofillMetrics& metric_logger);
 
   // Encodes the XML upload request from this FormStructure.
   bool EncodeUploadRequest(const FieldTypeSet& available_field_types,
                            bool form_was_autofilled,
                            std::string* encoded_xml) const;
@@ skipping 100 matching lines @@
   // Returns a FormData containing the data this form structure knows about.
   // |user_submitted| is currently always false.
   FormData ToFormData() const;
 
   bool operator==(const FormData& form) const;
   bool operator!=(const FormData& form) const;
 
  private:
   friend class FormStructureTest;
   FRIEND_TEST_ALL_PREFIXES(AutofillDownloadTest, QueryAndUploadTest);
+
+  // Initialize FormStructure object, called by constructors.
+  void Init(const FormData& form);
+
   // 64-bit hash of the string - used in FormSignature and unit-tests.
   static std::string Hash64Bit(const std::string& str);
 
   enum EncodeRequestType {
     QUERY,
     UPLOAD,
   };
 
   // Adds form info to |encompassing_xml_element|. |request_type| indicates if
   // it is a query or upload.
@@ skipping 48 matching lines @@
   int current_page_number_;
 
   // Total number of pages in the autofill flow. If this form doesn't belong
   // to any autofill flow, it is set to -1.
   int total_pages_;
 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
-  // State of the kEnableExperimentalFormFilling flag.
-  bool experimental_form_filling_enabled_;
+  // Whether the autocheckout feature is enabled for the site which contains
+  // this form.
+  bool autocheckout_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_