Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 118633004: New TOC for dart-by-example page (Closed)

Created:
6 years, 11 months ago by shailentuli
Modified:
6 years, 11 months ago
Reviewers:
mem, kathyw
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

New TOC for dart-by-example page R=mcampione@google.com Committed: e32a177

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed line between tutorial and dart-by-example in nav #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -32 lines) Patch
M src/site/_config.yml View 1 chunk +1 line, -1 line 0 comments Download
A + src/site/_includes/default_toc.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/site/_includes/guide_toc.html View 1 chunk +0 lines, -3 lines 0 comments Download
M src/site/_includes/header.html View 1 3 chunks +5 lines, -2 lines 0 comments Download
M src/site/articles/doc-comment-guidelines/index.markdown View 14 chunks +22 lines, -7 lines 0 comments Download
M src/site/articles/event-loop/index.markdown View 3 chunks +3 lines, -0 lines 0 comments Download
M src/site/articles/numeric-computation/index.markdown View 3 chunks +3 lines, -3 lines 0 comments Download
M src/site/articles/style-guide/index.markdown View 1 2 47 chunks +51 lines, -4 lines 0 comments Download
M src/site/articles/web-ui/spec.markdown View 16 chunks +16 lines, -4 lines 0 comments Download
M src/site/css/dart-style.css View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/site/dart-by-example/index.css View 1 chunk +8 lines, -2 lines 0 comments Download
M src/site/dart-by-example/index.markdown View 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/serverguide.markdown View 5 chunks +5 lines, -1 line 0 comments Download
M src/site/imgs/dart-sprite.png View 1 2 Binary file 0 comments Download
M src/site/imgs/dart-sprite-2x.png View 1 2 Binary file 0 comments Download
M src/site/index.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shailentuli
New TOC for dart-by-example. Also, added link to site nav. PTAL.
6 years, 11 months ago (2014-01-06 21:51:14 UTC) #1
shailentuli
Staged at: https://tocs-dot-dart-lang.appspot.com/
6 years, 11 months ago (2014-01-06 21:53:24 UTC) #2
mem
lgtm with one comment https://chromiumcodereview.appspot.com/118633004/diff/1/src/site/_includes/header.html File src/site/_includes/header.html (left): https://chromiumcodereview.appspot.com/118633004/diff/1/src/site/_includes/header.html#oldcode80 src/site/_includes/header.html:80: <li class="divider"></li> I would remove ...
6 years, 11 months ago (2014-01-06 22:09:20 UTC) #3
shailentuli
6 years, 11 months ago (2014-01-06 22:17:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as re32a177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698