Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 11833017: Android: Propagate timeouts when sharding(and retrying) tests. (Closed)

Created:
7 years, 11 months ago by nilesh
Modified:
7 years, 11 months ago
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach
Visibility:
Public.

Description

Android: Propagate timeouts when sharding(and retrying) tests. We use TestResult.GetAllBroken to identify and retry tests. However, this list is empty if a test times out (and the device is responsive). In this case we should propagate the timed_out info to the final result, which will report a STEP_FAILURE based on this information. Ex. bad run: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/6093/steps/sandbox_linux_unittests/logs/stdio BUG=169064 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175982

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/pylib/base_test_sharder.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
nilesh
7 years, 11 months ago (2013-01-09 22:01:10 UTC) #1
frankf
https://codereview.chromium.org/11833017/diff/1/build/android/pylib/base_test_sharder.py File build/android/pylib/base_test_sharder.py (right): https://codereview.chromium.org/11833017/diff/1/build/android/pylib/base_test_sharder.py#newcode144 build/android/pylib/base_test_sharder.py:144: self.tests += [t.name] @Craig: Lines 133-143 are completely breaking ...
7 years, 11 months ago (2013-01-09 22:11:27 UTC) #2
Isaac (away)
Agree w/ frankf. This is a hack, but the encapsulation was already broken. Sounds like ...
7 years, 11 months ago (2013-01-09 22:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11833017/1
7 years, 11 months ago (2013-01-09 23:00:00 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 11 months ago (2013-01-10 01:44:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11833017/1
7 years, 11 months ago (2013-01-10 01:45:58 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 02:05:38 UTC) #7
Message was sent while issue was closed.
Change committed as 175982

Powered by Google App Engine
This is Rietveld 408576698