build/android/pylib/base_test_sharder.py - Issue 11833017: Android: Propagate timeouts when sharding(and retrying) tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/base_test_sharder.py

Issue 11833017: Android: Propagate timeouts when sharding(and retrying) tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/base_test_sharder.py

diff --git a/build/android/pylib/base_test_sharder.py b/build/android/pylib/base_test_sharder.py

index 1c4559ad4582ddb2d757dd3fc5e5fa4bd27dcdd3..387038d070bd478b2ca4be287b7a96265ace8e05 100644

--- a/build/android/pylib/base_test_sharder.py

+++ b/build/android/pylib/base_test_sharder.py

@@ -136,6 +136,9 @@ class BaseTestSharder(object):

break

else:

final_results.ok += test_results.ok

+ # Timed out tests are not reported in GetAllBroken().

+ if test_results.timed_out:

+ final_results.timed_out = True

self.tests = []

for t in test_results.GetAllBroken():

self.tests += [t.name]

frankf 2013/01/09 22:11:28 @Craig: Lines 133-143 are completely breaking the

« no previous file with comments | « no previous file | no next file » | no next file with comments »