PRESUBMIT.py - Issue 11830057: Don't issue try jobs for OWNERS-only changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 11830057: Don't issue try jobs for OWNERS-only changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 17e309115b12ffa2cb32e45c72450f0ae58d06cf..a7384778306a74f5f4a0eea102bff9ba60509e61 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -829,7 +829,7 @@ def CheckChangeOnCommit(input_api, output_api):

def GetPreferredTrySlaves(project, change):

files = change.LocalPaths()

- if not files:

+ if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files):

M-A Ruel 2013/01/10 22:42:59 What about doing a whitelist instead? We currentl

return []

if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files):

« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »