Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: PRESUBMIT.py

Issue 11830057: Don't issue try jobs for OWNERS-only changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 811 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 input_api, output_api)) 822 input_api, output_api))
823 results.extend(input_api.canned_checks.CheckChangeHasDescription( 823 results.extend(input_api.canned_checks.CheckChangeHasDescription(
824 input_api, output_api)) 824 input_api, output_api))
825 results.extend(_CheckSubversionConfig(input_api, output_api)) 825 results.extend(_CheckSubversionConfig(input_api, output_api))
826 return results 826 return results
827 827
828 828
829 def GetPreferredTrySlaves(project, change): 829 def GetPreferredTrySlaves(project, change):
830 files = change.LocalPaths() 830 files = change.LocalPaths()
831 831
832 if not files: 832 if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files):
M-A Ruel 2013/01/10 22:42:59 What about doing a whitelist instead? We currentl
833 return [] 833 return []
834 834
835 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files): 835 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files):
836 return ['mac_rel', 'mac_asan'] 836 return ['mac_rel', 'mac_asan']
837 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 837 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
838 return ['win_rel'] 838 return ['win_rel']
839 if all(re.search('(^|[/_])android[/_.]', f) for f in files): 839 if all(re.search('(^|[/_])android[/_.]', f) for f in files):
840 return ['android_dbg', 'android_clang_dbg'] 840 return ['android_dbg', 'android_clang_dbg']
841 if all(re.search('^native_client_sdk', f) for f in files): 841 if all(re.search('^native_client_sdk', f) for f in files):
842 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk'] 842 return ['linux_nacl_sdk', 'win_nacl_sdk', 'mac_nacl_sdk']
(...skipping 15 matching lines...) Expand all
858 'win_aura', 858 'win_aura',
859 'win_rel', 859 'win_rel',
860 ] 860 ]
861 861
862 # Match things like path/aura/file.cc and path/file_aura.cc. 862 # Match things like path/aura/file.cc and path/file_aura.cc.
863 # Same for chromeos. 863 # Same for chromeos.
864 if any(re.search('[/_](aura|chromeos)', f) for f in files): 864 if any(re.search('[/_](aura|chromeos)', f) for f in files):
865 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] 865 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan']
866 866
867 return trybots 867 return trybots
OLDNEW
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698