Issue 11830056: Enable accelerated animations for orphaned layers

Issue 11830056: Enable accelerated animations for orphaned layers (Closed)

Created:
7 years, 11 months ago by ajuma

Modified:
7 years, 9 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@MakeLayerTreeHostAnimateLayersTakeWallClockTime

Visibility:
Public.

More Reviews

Description

Enable accelerated animations for orphaned layers This is the third step in the plan outlined at https://chromiumcodereview.appspot.com/11783037 and depends on https://chromiumcodereview.appspot.com/11783101 and https://bugs.webkit.org/show_bug.cgi?id=106594 BUG=129683

Patch Set 2 : Fix nit #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -26 lines)			Patch
M	cc/layer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layer.cc	View	1	2 chunks	+7 lines, -14 lines	0 comments	Download
M	cc/layer_animation_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/layer_animation_controller.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	cc/layer_animation_value_observer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layer_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layer_impl.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	cc/layer_tree_host.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	cc/test/animation_test_common.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/test/animation_test_common.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/compositor_bindings/web_layer_tree_view_impl.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	webkit/compositor_bindings/web_layer_tree_view_impl.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://chromiumcodereview.appspot.com/11830056/diff/1/cc/layer_animation_controller.cc File cc/layer_animation_controller.cc (right): https://chromiumcodereview.appspot.com/11830056/diff/1/cc/layer_animation_controller.cc#newcode239 cc/layer_animation_controller.cc:239: while ((obs = it.GetNext()) != NULL) use braces ...

7 years, 11 months ago (2013-01-14 21:57:27 UTC) #2

ajuma

7 years, 11 months ago (2013-01-15 16:18:42 UTC) #3

Fixed nit.

https://chromiumcodereview.appspot.com/11830056/diff/1/cc/layer_animation_con...
File cc/layer_animation_controller.cc (right):

https://chromiumcodereview.appspot.com/11830056/diff/1/cc/layer_animation_con...
cc/layer_animation_controller.cc:239: while ((obs = it.GetNext()) != NULL)
On 2013/01/14 21:57:27, jamesr wrote:
> use braces since the block is more than 1 line

Done.

Expand Messages | Collapse Messages