[Telemetry] Fixing credentials login behaviour in case the user is already logged in and using --do…

[Telemetry] Fixing credentials login behaviour in case the user is already logged in and using --dont-override-profile.

Currently the page will timeout and fail if it's already logged in, since it doesn't see the login form.
I also added a warning when users specify --dont-override-profile, and a facebook_backend_unittest.py.

Note that this depends on https://codereview.chromium.org/11745002/ to work properly, since currently
the extra quotes around the user-agent string will cause us to be redirected to the wrong version of
accounts.google.com, so we won't correctly detect that we're logged in.

BUG=160268
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176152

[hartmanng, 2013-01-10 17:01:36]

Please take a look.

[nduca, 2013-01-10 18:20:02]

lgtm

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/bro...
File tools/telemetry/telemetry/browser_backend.py (right):

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/bro...
tools/telemetry/telemetry/browser_backend.py:151: logging.warning('Not
overriding profile. This can cause unexpected '
If your intent is to make this visible to users, then we should sys.stderr.write
this

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/for...
File tools/telemetry/telemetry/form_based_credentials_backend.py (right):

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/for...
tools/telemetry/telemetry/form_based_credentials_backend.py:19:
'document.querySelector("#%s")!== null' % login_form_id) or \
you might not need \ since its inside a ( block from Evaluate

[hartmanng, 2013-01-10 18:36:04]

Thanks!

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/bro...
File tools/telemetry/telemetry/browser_backend.py (right):

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/bro...
tools/telemetry/telemetry/browser_backend.py:151: logging.warning('Not
overriding profile. This can cause unexpected '
On 2013/01/10 18:20:02, nduca wrote:
> If your intent is to make this visible to users, then we should
sys.stderr.write
> this

Done.

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/for...
File tools/telemetry/telemetry/form_based_credentials_backend.py (right):

https://codereview.chromium.org/11828048/diff/1/tools/telemetry/telemetry/for...
tools/telemetry/telemetry/form_based_credentials_backend.py:19:
'document.querySelector("#%s")!== null' % login_form_id) or \
On 2013/01/10 18:20:02, nduca wrote:
> you might not need \ since its inside a ( block from Evaluate

nah, the ( block ends right before the 'or'.

[commit-bot: I haz the power, 2013-01-10 18:36:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11828048/4001

[commit-bot: I haz the power, 2013-01-10 21:08:28]

Change committed as 176152