tools/telemetry/telemetry/facebook_credentials_backend.py - Issue 11828048: [Telemetry] Fixing credentials login behaviour in case the user is already logged in and using --do…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/facebook_credentials_backend.py

Issue 11828048: [Telemetry] Fixing credentials login behaviour in case the user is already logged in and using --do… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/browser_backend.py ('k') | tools/telemetry/telemetry/facebook_credentials_backend_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/facebook_credentials_backend.py

diff --git a/tools/telemetry/telemetry/facebook_credentials_backend.py b/tools/telemetry/telemetry/facebook_credentials_backend.py

index abde849406d36234456231bcef1037c10a05368b..dc4219a7900123a9c7864d4e1dd6b6b78c5930c7 100644

--- a/tools/telemetry/telemetry/facebook_credentials_backend.py

+++ b/tools/telemetry/telemetry/facebook_credentials_backend.py

@@ -15,10 +15,14 @@ class FacebookCredentialsBackend(

return 'http://www.facebook.com/'

@property

- def form_id(self):

+ def login_form_id(self):

return 'login_form'

@property

+ def already_logged_in_element_id(self):

+ return 'fbNotificationsList'

+ @property

def login_input_id(self):

return 'email'

« no previous file with comments | « tools/telemetry/telemetry/browser_backend.py ('k') | tools/telemetry/telemetry/facebook_credentials_backend_unittest.py » ('j') | no next file with comments »