Issue 11827010: Fixes the policy to choose the notifications for popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11827010: Fixes the policy to choose the notifications for popups. (Closed)

Created:
7 years, 11 months ago by Jun Mukai

Modified:
7 years, 11 months ago

Reviewers:
miket_OOO, dharcourt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes the policy to choose the notifications for popups. The existing code: choose the newer items, the new code: choose the older items I wrote this existing code, but I was wrong. BUG=165768 TEST=message_center_unittests passed Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175872

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -16 lines)			Patch
M	ui/message_center/notification_list.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/message_center/notification_list.cc	View		3 chunks	+18 lines, -14 lines	0 comments	Download
M	ui/message_center/notification_list_unittest.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/11827010/6001

7 years, 11 months ago (2013-01-09 17:46:59 UTC) #3

Message was sent while issue was closed.

Change committed as 175872

Expand Messages | Collapse Messages